[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/11] target/rx: Fix setting of FPSW.CE
From: |
Richard Henderson |
Subject: |
[PATCH 08/11] target/rx: Fix setting of FPSW.CE |
Date: |
Wed, 26 May 2021 21:14:02 -0700 |
The existing check was completely wrong, confused about the
definition of the (previous) float_flag_{input,output}_denormal
flags, then making sure that DN, the flush-to-zero bit, was off.
Update for the introduction of float_flag_inorm_denormal and
float_flag_result_denormal, taking into account that DN now sets
the softfloat flush-to-zero bits.
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/rx/op_helper.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
index b1772e9538..c2e4f9a5e3 100644
--- a/target/rx/op_helper.c
+++ b/target/rx/op_helper.c
@@ -97,9 +97,11 @@ static void update_fpsw(CPURXState *env, float32 ret,
uintptr_t retaddr)
if (xcpt & float_flag_inexact) {
SET_FPSW(X);
}
- if ((xcpt & (float_flag_iflush_denormal
- | float_flag_oflush_denormal))
- && !FIELD_EX32(env->fpsw, FPSW, DN)) {
+ /*
+ * If any input or output denormals, not flushed to zero, raise CE:
+ * unimplemented processing has been encountered.
+ */
+ if (xcpt & (float_flag_inorm_denormal | float_flag_result_denormal)) {
env->fpsw = FIELD_DP32(env->fpsw, FPSW, CE, 1);
}
--
2.25.1
- [PATCH 03/11] softfloat: Introduce float_flag_inorm_denormal, (continued)
- [PATCH 03/11] softfloat: Introduce float_flag_inorm_denormal, Richard Henderson, 2021/05/27
- [PATCH 01/11] softfloat: Rename float_flag_input_denormal to float_flag_iflush_denormal, Richard Henderson, 2021/05/27
- [PATCH 07/11] target/rx: Use FloatRoundMode in helper_set_fpsw, Richard Henderson, 2021/05/27
- [PATCH 02/11] softfloat: Rename float_flag_output_denormal to float_flag_oflush_denormal, Richard Henderson, 2021/05/27
- [PATCH 06/11] target/rx: Handle the FPSW.DN bit in helper_set_fpsw, Richard Henderson, 2021/05/27
- [PATCH 08/11] target/rx: Fix setting of FPSW.CE,
Richard Henderson <=
- [PATCH 09/11] target/mips: Drop inline markers from msa_helper.c, Richard Henderson, 2021/05/27
- [PATCH 10/11] target/mips: Do not check MSACSR_FS_MASK in update_msacsr, Richard Henderson, 2021/05/27
- [PATCH 04/11] softfloat: Introduce float_flag_result_denormal, Richard Henderson, 2021/05/27
- [PATCH 05/11] target/i386: Use float_flag_inorm_denormal, Richard Henderson, 2021/05/27
- [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr, Richard Henderson, 2021/05/27