Re: [PATCH 1/1] yank: Unregister function when using TLS migration

[Leonardo Brás]

Hello Lukas, thanks for this feedback!

On Wed, 2021-05-26 at 23:24 +0200, Lukas Straub wrote:
> > diff --git a/migration/multifd.c b/migration/multifd.c
> > index 0a4803cfcc..be8656f4c0 100644
> > --- a/migration/multifd.c
> > +++ b/migration/multifd.c
> > @@ -987,8 +987,9 @@ int multifd_load_cleanup(Error **errp)
> >      for (i = 0; i < migrate_multifd_channels(); i++) {
> >          MultiFDRecvParams *p = &multifd_recv_state->params[i];
> >  
> > -        if (object_dynamic_cast(OBJECT(p->c),
> > TYPE_QIO_CHANNEL_SOCKET)
> > -            && OBJECT(p->c)->ref == 1) {
> > +        if ((object_dynamic_cast(OBJECT(p->c),
> > TYPE_QIO_CHANNEL_SOCKET) ||
> > +            (object_dynamic_cast(OBJECT(p->c),
> > TYPE_QIO_CHANNEL_TLS)))  &&
> > +            OBJECT(p->c)->ref == 1) {
> >              yank_unregister_function(MIGRATION_YANK_INSTANCE,
> >                                       migration_yank_iochannel,
> >                                       QIO_CHANNEL(p->c));
> 
> The code here should be the same as in channel_close. So for the
> tls-channel you have to unregister with QIO_CHANNEL(tioc->master)
> like
> below.

ok, sure, I will send a v2.

Thanks!


> 
> Regards,
> Lukas Straub