Re: [PULL 00/26] Misc patches for 2021-05-20

[Paolo Bonzini]

On 20/05/21 15:26, Peter Maydell wrote:
> WARNING: Project specifies a minimum meson_version '>=0.55.0' but uses
> features which were added in newer versions:
>   * 0.57.0: {'test() timeout <= 0'}
>
> ERROR: Could not detect Ninja v1.8.2 or newer
>
> (This system has ninja-build 1.7.2.)

What OS is it, and is there any chance of updating it?  ninja 1.7 was 
released in 2017, and I checked that all the supported OSes for QEMU 
have 1.8 before sending the pull request.

> Also, my OSX build which I configure with
> ../..configure --extra-cflags='-fdiagnostics-color=never -Werror
> -Wno-error=deprecated-declarations'
>
> now triggers a meson.build warning:
>
> ../../meson.build:118: WARNING: Consider using the built-in werror
> option instead of using "-Werror".
> ../../meson.build:120: WARNING: Consider using the built-in werror
> option instead of using "-Werror".
> ../../meson.build:122: WARNING: Consider using the built-in werror
> option instead of using "-Werror".

Which makes sense since we have --enable/--disable-werror.

> Also also, dropping the merge commit reveals that the pullreq somehow
> broke the build trees such that trying to do a build on master no
> longer works:  [...] This seems like a meson bug

It is and has been fixed since in Meson, but the older version obviously 
doesn't have the fix.

Paolo