Re: [PULL 00/26] Misc patches for 2021-05-20

[no-reply]

Patchew URL: 
20210520082257.187061-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210520082257.187061-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210520082257.187061-1-pbonzini@redhat.com
Subject: [PULL 00/26] Misc patches for 2021-05-20

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210519163448.2154339-1-philmd@redhat.com -> 
patchew/20210519163448.2154339-1-philmd@redhat.com
 * [new tag]         patchew/20210520082257.187061-1-pbonzini@redhat.com -> 
patchew/20210520082257.187061-1-pbonzini@redhat.com
Switched to a new branch 'test'
fd40ea5 scsi-generic: pass max_segments via max_iov field in BlockLimits
37a6979 qemu-config: load modules when instantiating option groups
32b94da vl: allow not specifying size in -m when using -M memory-backend
675997a replication: move include out of root directory
2e3973b remove qemu-options* from root directory
5d724e9 meson: Set implicit_include_directories to false
ecc742f tests/qtest/fuzz: Fix build failure
3e04412 KVM: Dirty ring support
a954451 KVM: Disable manual dirty log when dirty ring enabled
24a98e2 KVM: Add dirty-ring-size property
589af7b KVM: Cache kvm slot dirty bitmap size
73442ac KVM: Simplify dirty log sync in kvm_set_phys_mem
53278ea KVM: Provide helper to sync dirty bitmap from slot to ramblock
ea3b6f9 KVM: Provide helper to get kvm dirty log
51d5550 KVM: Create the KVMSlot dirty bitmap on flag changes
c834893 KVM: Use a big lock to replace per-kml slots_lock
1f2cf76 memory: Introduce log_sync_global() to memory listener
d92fe4b KVM: do not allow setting properties at runtime
75d0f51 qtest: add a QOM object for qtest
50a63a3 object: add more commands to preconfig mode
5681fd8 meson: bump submodule to 0.57.2
3838574 i386/cpu: Expose AVX_VNNI instruction to guest
a531870 hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
8431b7a configure: simplify assignment to GIT_SUBMODULES
f35bc5c configure: check for submodules if --with-git-submodules=ignore
dad7063 configure: Only clone softfloat-3 repositories if TCG is enabled

=== OUTPUT BEGIN ===
1/26 Checking commit dad70637e0bc (configure: Only clone softfloat-3 
repositories if TCG is enabled)
2/26 Checking commit f35bc5c7fde4 (configure: check for submodules if 
--with-git-submodules=ignore)
3/26 Checking commit 8431b7a87054 (configure: simplify assignment to 
GIT_SUBMODULES)
4/26 Checking commit a531870aa3c8 (hw/mem/nvdimm: Use Kconfig 'imply' instead 
of 'depends on')
5/26 Checking commit 3838574cd38d (i386/cpu: Expose AVX_VNNI instruction to 
guest)
6/26 Checking commit 5681fd804f8f (meson: bump submodule to 0.57.2)
7/26 Checking commit 50a63a3492af (object: add more commands to preconfig mode)
8/26 Checking commit 75d0f5167f5b (qtest: add a QOM object for qtest)
9/26 Checking commit d92fe4b72972 (KVM: do not allow setting properties at 
runtime)
ERROR: line over 90 characters
#33: FILE: accel/kvm/kvm-all.c:3115:
+        error_setg(errp, "Cannot set properties after the accelerator has been 
initialized");

ERROR: line over 90 characters
#45: FILE: accel/kvm/kvm-all.c:3134:
+        error_setg(errp, "Cannot set properties after the accelerator has been 
initialized");

total: 2 errors, 0 warnings, 37 lines checked

Patch 9/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/26 Checking commit 1f2cf76b0ea0 (memory: Introduce log_sync_global() to 
memory listener)
11/26 Checking commit c8348939ca12 (KVM: Use a big lock to replace per-kml 
slots_lock)
12/26 Checking commit 51d55505d416 (KVM: Create the KVMSlot dirty bitmap on 
flag changes)
13/26 Checking commit ea3b6f9db553 (KVM: Provide helper to get kvm dirty log)
14/26 Checking commit 53278ea4368f (KVM: Provide helper to sync dirty bitmap 
from slot to ramblock)
15/26 Checking commit 73442acd2e96 (KVM: Simplify dirty log sync in 
kvm_set_phys_mem)
16/26 Checking commit 589af7b254d2 (KVM: Cache kvm slot dirty bitmap size)
17/26 Checking commit 24a98e28b284 (KVM: Add dirty-ring-size property)
ERROR: line over 90 characters
#59: FILE: accel/kvm/kvm-all.c:3206:
+        error_setg(errp, "Cannot set properties after the accelerator has been 
initialized");

total: 1 errors, 0 warnings, 94 lines checked

Patch 17/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/26 Checking commit a954451955ef (KVM: Disable manual dirty log when dirty 
ring enabled)
19/26 Checking commit 3e04412f7670 (KVM: Dirty ring support)
WARNING: line over 80 characters
#451: FILE: accel/kvm/kvm-all.c:2466:
+                             "Suggested mininum value is 1024.", 
strerror(-ret));

total: 0 errors, 1 warnings, 498 lines checked

Patch 19/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/26 Checking commit ecc742f3f5f3 (tests/qtest/fuzz: Fix build failure)
21/26 Checking commit 5d724e9361f4 (meson: Set implicit_include_directories to 
false)
22/26 Checking commit 2e3973bf8de9 (remove qemu-options* from root directory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
rename from qemu-options.h

ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: include/qemu/qemu-options.h:33:
+#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask)     \
+    opt_enum,

total: 1 errors, 1 warnings, 79 lines checked

Patch 22/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

23/26 Checking commit 675997a53ff0 (replication: move include out of root 
directory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
rename from replication.h

total: 0 errors, 1 warnings, 48 lines checked

Patch 23/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/26 Checking commit 32b94da773e7 (vl: allow not specifying size in -m when 
using -M memory-backend)
25/26 Checking commit 37a69797e76c (qemu-config: load modules when 
instantiating option groups)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 61 lines checked

Patch 25/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/26 Checking commit fd40ea59615b (scsi-generic: pass max_segments via max_iov 
field in BlockLimits)
WARNING: line over 80 characters
#51: FILE: hw/scsi/scsi-generic.c:186:
+            max_transfer = MIN_NON_ZERO(max_transfer, max_iov * 
qemu_real_host_page_size)

total: 0 errors, 1 warnings, 23 lines checked

Patch 26/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210520082257.187061-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210520082257.187061-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com