[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers |
Date: |
Wed, 19 May 2021 21:40:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/19/21 9:20 PM, Richard Henderson wrote:
> On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
>> The series is decomposed as:
>> - cleanups (1-6)
>> - clean ldst API using macros (7-13)
>> - add aligned ldst methods (14)
>> - add aligned memory methods (15-16)
>> - similar changes in virtio (17-24)
>> - use the new methods on vring aligned values (25)
>>
>> There are some checkpatch errors related to the macro used.
>
> I think we should emphasize the atomicness of the access as opposed to
> the alignedness. That's the only thing that's important to virtio.
>
> Thus s/aligned/atomic/g and use qatomic_read/qatomic_set.
OK.
Do you think patches 1-6, 17 (Use correct type sizes) could
go in meanwhile, or should I repost them separately?
- [RFC PATCH 18/25] hw/virtio: Introduce VIRTIO_LD_CONVERT() macro, (continued)
- [RFC PATCH 18/25] hw/virtio: Introduce VIRTIO_LD_CONVERT() macro, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 19/25] hw/virtio: Use LD_CONVERT macro to emit 16-bit unsigned load/store code, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 20/25] hw/virtio: Introduce VIRTIO_ST_CONVERT() macro, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 21/25] hw/virtio: Use ST_CONVERT() macro to emit 16-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 22/25] hw/virtio: Use LDST_CONVERT macro to emit 32-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 24/25] hw/virtio: Add methods for aligned pointer access, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 23/25] hw/virtio: Use LDST_CONVERT macro to emit 64-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 25/25] hw/virtio: Optimize accesses on vring aligned pointers, Philippe Mathieu-Daudé, 2021/05/18
- Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers, no-reply, 2021/05/18
- Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers, Richard Henderson, 2021/05/19
- Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers,
Philippe Mathieu-Daudé <=