|
From: | Richard Henderson |
Subject: | Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers |
Date: | Wed, 19 May 2021 14:20:43 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
The series is decomposed as: - cleanups (1-6) - clean ldst API using macros (7-13) - add aligned ldst methods (14) - add aligned memory methods (15-16) - similar changes in virtio (17-24) - use the new methods on vring aligned values (25) There are some checkpatch errors related to the macro used.
I think we should emphasize the atomicness of the access as opposed to the alignedness. That's the only thing that's important to virtio.
Thus s/aligned/atomic/g and use qatomic_read/qatomic_set. r~
[Prev in Thread] | Current Thread | [Next in Thread] |