[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 27/50] target/i386: Fix the comment for repz_opt
From: |
Richard Henderson |
Subject: |
[PULL 27/50] target/i386: Fix the comment for repz_opt |
Date: |
Wed, 19 May 2021 13:30:27 -0500 |
After fixing a typo in the comment, fixup for CODING_STYLE.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210514151342.384376-28-richard.henderson@linaro.org>
---
target/i386/tcg/translate.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index b9b94f0625..226fb62ccb 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -8521,15 +8521,10 @@ static void i386_tr_init_disas_context(DisasContextBase
*dcbase, CPUState *cpu)
dc->cpuid_xsave_features = env->features[FEAT_XSAVE];
dc->jmp_opt = !(dc->base.singlestep_enabled ||
(flags & (HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
- /* Do not optimize repz jumps at all in icount mode, because
- rep movsS instructions are execured with different paths
- in !repz_opt and repz_opt modes. The first one was used
- always except single step mode. And this setting
- disables jumps optimization and control paths become
- equivalent in run and single step modes.
- Now there will be no jump optimization for repz in
- record/replay modes and there will always be an
- additional step for ecx=0 when icount is enabled.
+ /*
+ * If jmp_opt, we want to handle each string instruction individually.
+ * For icount also disable repz optimization so that each iteration
+ * is accounted separately.
*/
dc->repz_opt = !dc->jmp_opt && !(tb_cflags(dc->base.tb) & CF_USE_ICOUNT);
--
2.25.1
- [PULL 22/50] target/i386: Reduce DisasContext.prefix to uint8_t, (continued)
- [PULL 22/50] target/i386: Reduce DisasContext.prefix to uint8_t, Richard Henderson, 2021/05/19
- [PULL 23/50] target/i386: Reduce DisasContext.vex_[lv] to uint8_t, Richard Henderson, 2021/05/19
- [PULL 21/50] target/i386: Reduce DisasContext.override to int8_t, Richard Henderson, 2021/05/19
- [PULL 29/50] target/i386: Add stub generator for helper_set_dr, Richard Henderson, 2021/05/19
- [PULL 19/50] target/i386: Remove DisasContext.f_st as unused, Richard Henderson, 2021/05/19
- [PULL 20/50] target/i386: Reduce DisasContext.flags to uint32_t, Richard Henderson, 2021/05/19
- [PULL 30/50] target/i386: Assert !SVME for user-only, Richard Henderson, 2021/05/19
- [PULL 26/50] target/i386: Reduce DisasContext jmp_opt, repz_opt to bool, Richard Henderson, 2021/05/19
- [PULL 32/50] target/i386: Implement skinit in translate.c, Richard Henderson, 2021/05/19
- [PULL 31/50] target/i386: Assert !GUEST for user-only, Richard Henderson, 2021/05/19
- [PULL 27/50] target/i386: Fix the comment for repz_opt,
Richard Henderson <=
- [PULL 28/50] target/i386: Reorder DisasContext members, Richard Henderson, 2021/05/19
- [PULL 36/50] target/i386: Tidy svm_check_intercept from tcg, Richard Henderson, 2021/05/19
- [PULL 25/50] target/i386: Leave TF in DisasContext.flags, Richard Henderson, 2021/05/19
- [PULL 24/50] target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t, Richard Henderson, 2021/05/19
- [PULL 39/50] target/i386: Cleanup read_crN, write_crN, lmsw, Richard Henderson, 2021/05/19
- [PULL 34/50] target/i386: Mark some helpers as noreturn, Richard Henderson, 2021/05/19
- [PULL 37/50] target/i386: Remove pc_start argument to gen_svm_check_intercept, Richard Henderson, 2021/05/19
- [PULL 35/50] target/i386: Simplify gen_debug usage, Richard Henderson, 2021/05/19
- [PULL 38/50] target/i386: Remove user stub for cpu_vmexit, Richard Henderson, 2021/05/19
- [PULL 33/50] target/i386: Eliminate SVM helpers for user-only, Richard Henderson, 2021/05/19