qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/21] block/copy-before-write: make public block driver


From: Max Reitz
Subject: Re: [PATCH 19/21] block/copy-before-write: make public block driver
Date: Tue, 18 May 2021 16:46:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
Finally, copy-before-write gets own .bdrv_open and .bdrv_close
handlers, block_init() call and becomes available through bdrv_open().

To achieve this:

  - cbw_init gets unused flags argument and becomes cbw_open
  - block_copy_state_free() call moved to new cbw_close()
  - in bdrv_cbw_append:
    - options are completed with driver and node-name, and we can simply
      use bdrv_insert_node() to do both open and drained replacing
  - in bdrv_cbw_drop:
    - cbw_close() is now responsible for freeing s->bcs, so don't do it
      here

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  block/copy-before-write.c | 60 ++++++++++++++++++---------------------
  1 file changed, 28 insertions(+), 32 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]