qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/21] block/backup: move cluster size calculation to block-c


From: Max Reitz
Subject: Re: [PATCH 09/21] block/backup: move cluster size calculation to block-copy
Date: Mon, 17 May 2021 19:09:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
The main consumer of cluster-size is block-copy. Let's calculate it
here instead of passing through backup-top.

We are going to publish copy-before-write filter soon, so it will be
created through options. But we don't want for now to make explicit
option for cluster-size, let's continue to calculate it automatically.
So, now is the time to get rid of cluster_size argument for
bdrv_cbw_append().

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  block/copy-before-write.h  |  1 -
  include/block/block-copy.h |  5 ++--
  block/backup.c             | 58 ++++++--------------------------------
  block/block-copy.c         | 47 +++++++++++++++++++++++++++++-
  block/copy-before-write.c  | 10 +++----
  5 files changed, 62 insertions(+), 59 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]