Re: [PULL 21/38] tcg/tci: Implement the disassembler properly

[Richard Henderson]

On 5/15/21 5:57 AM, Philippe Mathieu-Daudé wrote:
> > +    switch (op) {
> > +    case INDEX_op_br:
> > +    case INDEX_op_call:
> > +    case INDEX_op_exit_tb:
> > +    case INDEX_op_goto_tb:
> > +        tci_args_l(&tb_ptr, &ptr);
> > +        info->fprintf_func(info->stream, "%-12s  %p", op_name, ptr);
> > +        break;
>
> I just realized ptr can be NULL:
>
>    "tcg/tci: Implement goto_ptr"
>
>    The check in tcg_prologue_init is disabled because TCI does
>    want to use NULL to indicate exit, as opposed to branching to
>    a real epilogue.

That's INDEX_op_goto_ptr, which is none of these.

But INDEX_op_exit_tb can have a null operand.
What's wrong with the rendering done by %p?


r~