Re: [PATCH v6 69/82] target/arm: Share table of sve load functions

[Richard Henderson]

On 5/13/21 9:25 AM, Peter Maydell wrote:
> > @@ -5551,7 +5547,9 @@ static void do_ldrq(DisasContext *s, int zt, int pg, 
> > TCGv_i64 addr, int msz)
> >       t_pg = tcg_temp_new_ptr();
> >       tcg_gen_addi_ptr(t_pg, cpu_env, poff);
> >
> > -    fns[s->be_data == MO_BE][msz](cpu_env, t_pg, addr, t_desc);
> > +    gen_helper_gvec_mem *fn
> > +        = ldr_fns[s->mte_active[0]][s->be_data == MO_BE][dtype][0];
> > +    fn(cpu_env, t_pg, addr, t_desc);
>
> Previously we didn't take account of MTE state, and now we do.
> Is this an intentional behaviour change?

Amusing that I didn't even notice.

> If it's fixing a bug, the commit message should say so.

Yes, this is fixing a bug in LDRQ.


r~