[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers |
|
Date: |
Sat, 15 May 2021 11:02:28 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 1:57 AM, Richard Henderson wrote:
> As noted by qemu-plugins.h, plugins can neither read nor write
> guest registers.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> accel/tcg/plugin-helpers.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/plugin-helpers.h b/accel/tcg/plugin-helpers.h
> index 853bd21677..9829abe4a9 100644
> --- a/accel/tcg/plugin-helpers.h
> +++ b/accel/tcg/plugin-helpers.h
> @@ -1,4 +1,4 @@
> #ifdef CONFIG_PLUGIN
> -DEF_HELPER_2(plugin_vcpu_udata_cb, void, i32, ptr)
> -DEF_HELPER_4(plugin_vcpu_mem_cb, void, i32, i32, i64, ptr)
> +DEF_HELPER_FLAGS_2(plugin_vcpu_udata_cb, TCG_CALL_NO_RWG, void, i32, ptr)
> +DEF_HELPER_FLAGS_4(plugin_vcpu_mem_cb, TCG_CALL_NO_RWG, void, i32, i32, i64,
> ptr)
> #endif
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v6 02/26] tcg: Add tcg_call_flags, (continued)
- [PATCH v6 02/26] tcg: Add tcg_call_flags, Richard Henderson, 2021/05/02
- [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode, Richard Henderson, 2021/05/02
- [PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb, Richard Henderson, 2021/05/02
- [PATCH v6 06/26] tcg: Store the TCGHelperInfo in the TCGOp for call, Richard Henderson, 2021/05/02
- [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers, Richard Henderson, 2021/05/02
- Re: [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers,
Philippe Mathieu-Daudé <=
- [PATCH v6 07/26] tcg: Add tcg_call_func, Richard Henderson, 2021/05/02
- [PATCH v6 08/26] tcg: Build ffi data structures for helpers, Richard Henderson, 2021/05/02
- [PATCH v6 10/26] tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order, Richard Henderson, 2021/05/02
- [PATCH v6 13/26] tcg/tci: Emit setcond before brcond, Richard Henderson, 2021/05/02
- [PATCH v6 11/26] tcg/tci: Use ffi for calls, Richard Henderson, 2021/05/02