Re: [PULL 2/5] Remove the deprecated moxie target

[Philippe Mathieu-Daudé]

On 5/12/21 6:24 PM, Markus Armbruster wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> There are no known users of this CPU anymore, and there are no
> binaries available online which could be used for regression tests,
> so the code has likely completely bit-rotten already. It's been
> marked as deprecated since two releases now and nobody spoke up
> that there is still a need to keep it, thus let's remove it now.

Isn't it already in a pull request sent by Thomas last week?
(I ask because I based a pair of branches on it)

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20210430160355.698194-1-thuth@redhat.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> [Commit message typos fixed, trivial conflicts resolved]
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/system/deprecated.rst                |   8 -
>  docs/system/removed-features.rst          |   7 +
>  default-configs/devices/moxie-softmmu.mak |   5 -
>  default-configs/targets/moxie-softmmu.mak |   2 -
>  meson.build                               |   1 -
>  qapi/machine.json                         |   2 +-
>  qapi/misc-target.json                     |   2 +-
>  include/disas/dis-asm.h                   |   1 -
>  include/elf.h                             |   3 -
>  include/exec/poison.h                     |   2 -
>  include/hw/elf_ops.h                      |   8 -
>  include/sysemu/arch_init.h                |   1 -
>  target/moxie/cpu-param.h                  |  17 -
>  target/moxie/cpu.h                        | 123 ---
>  target/moxie/helper.h                     |   5 -
>  target/moxie/machine.h                    |   1 -
>  target/moxie/mmu.h                        |  19 -
>  disas/moxie.c                             | 360 ---------
>  hw/moxie/moxiesim.c                       | 155 ----
>  softmmu/arch_init.c                       |   2 -
>  target/moxie/cpu.c                        | 161 ----
>  target/moxie/helper.c                     | 120 ---
>  target/moxie/machine.c                    |  19 -
>  target/moxie/mmu.c                        |  32 -
>  target/moxie/translate.c                  | 892 ----------------------
>  tests/qtest/boot-serial-test.c            |   8 -
>  tests/qtest/machine-none-test.c           |   1 -
>  fpu/softfloat-specialize.c.inc            |   2 +-
>  .gitlab-ci.yml                            |   6 +-
>  MAINTAINERS                               |   8 -
>  disas/meson.build                         |   1 -
>  hw/Kconfig                                |   1 -
>  hw/meson.build                            |   1 -
>  hw/moxie/Kconfig                          |   3 -
>  hw/moxie/meson.build                      |   4 -
>  target/meson.build                        |   1 -
>  target/moxie/meson.build                  |  14 -
>  tests/qtest/meson.build                   |   2 -
>  38 files changed, 13 insertions(+), 1987 deletions(-)
>  delete mode 100644 default-configs/devices/moxie-softmmu.mak
>  delete mode 100644 default-configs/targets/moxie-softmmu.mak
>  delete mode 100644 target/moxie/cpu-param.h
>  delete mode 100644 target/moxie/cpu.h
>  delete mode 100644 target/moxie/helper.h
>  delete mode 100644 target/moxie/machine.h
>  delete mode 100644 target/moxie/mmu.h
>  delete mode 100644 disas/moxie.c
>  delete mode 100644 hw/moxie/moxiesim.c
>  delete mode 100644 target/moxie/cpu.c
>  delete mode 100644 target/moxie/helper.c
>  delete mode 100644 target/moxie/machine.c
>  delete mode 100644 target/moxie/mmu.c
>  delete mode 100644 target/moxie/translate.c
>  delete mode 100644 hw/moxie/Kconfig
>  delete mode 100644 hw/moxie/meson.build
>  delete mode 100644 target/moxie/meson.build