[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 30/33] migration: do not restart VM after successful snapshot-
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load |
|
Date: |
Tue, 11 May 2021 18:06:59 +0100 |
|
User-agent: |
Mutt/2.0.6 (2021-03-06) |
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote:
> The HMP loadvm code is calling load_snapshot rather than
> qmp_snapshot_load, in order to bypass the job infrastructure. The code
> around it is almost the same, with one difference: hmp_loadvm is
> restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so
> if load_snapshot succeeds.
>
> Fix the bug in QMP by moving the common code to load_snapshot.
This doesn't appear to have actually fixed the HMP regression.
Instead I think it is duplicated the HMP bug in the QMP code
too.
See the 068 iotest enhancement here that validates the expected
state on success:
https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03091.html
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL 25/33] target/i386: pass cr3 to mmu_translate, (continued)
- [PULL 25/33] target/i386: pass cr3 to mmu_translate, Paolo Bonzini, 2021/05/11
- [PULL 24/33] target/i386: extract mmu_translate, Paolo Bonzini, 2021/05/11
- [PULL 28/33] target/i386: use mmu_translate for NPT walk, Paolo Bonzini, 2021/05/11
- [PULL 21/33] accel: add init_accel_cpu for adapting accel behavior to CPU type, Paolo Bonzini, 2021/05/11
- [PULL 27/33] target/i386: allow customizing the next phase of the translation, Paolo Bonzini, 2021/05/11
- [PULL 31/33] qemu-option: support accept-any QemuOptsList in qemu_opts_absorb_qdict, Paolo Bonzini, 2021/05/11
- [PULL 30/33] migration: do not restart VM after successful snapshot-load, Paolo Bonzini, 2021/05/11
- [PULL 16/33] i386: split off sysemu part of cpu.c, Paolo Bonzini, 2021/05/11
- Re: [PULL 00/33] Misc (mostly i386) patches for 2021-05-11, no-reply, 2021/05/11
- Re: [PULL 00/33] Misc (mostly i386) patches for 2021-05-11, Peter Maydell, 2021/05/12