Re: [PULL 00/33] Misc (mostly i386) patches for 2021-05-11

[no-reply]

Patchew URL: 
20210511081350.419428-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210511081350.419428-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210511081350.419428-1-pbonzini@redhat.com
Subject: [PULL 00/33] Misc (mostly i386) patches for 2021-05-11

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210511081350.419428-1-pbonzini@redhat.com -> 
patchew/20210511081350.419428-1-pbonzini@redhat.com
Switched to a new branch 'test'
11165dc coverity-scan: list components, move model to scripts/coverity-scan
8c04d1d configure: fix detection of gdbus-codegen
72d3908 qemu-option: support accept-any QemuOptsList in qemu_opts_absorb_qdict
fa0a3a0 migration: do not restart VM after successful snapshot-load
314ce22 main-loop: remove dead code
fab0cca target/i386: use mmu_translate for NPT walk
fbfc2e7 target/i386: allow customizing the next phase of the translation
b41eebf target/i386: extend pg_mode to more CR0 and CR4 bits
e73fad8 target/i386: pass cr3 to mmu_translate
1d5c833 target/i386: extract mmu_translate
82189eb target/i386: move paging mode constants from SVM to cpu.h
e158c09 target/i386: merge SVM_NPTEXIT_* with PF_ERROR_* constants
e6027a1 accel: add init_accel_cpu for adapting accel behavior to CPU type
a68180f accel: move call to accel_init_interfaces
95d9318 i386: make cpu_load_efer sysemu-only
8e1f9eb target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu
cac1ed0 target/i386: gdbstub: introduce aux functions to read/write CS64 regs
92bc080 i386: split off sysemu part of cpu.c
f80829b i386: split seg_helper into user-only and sysemu parts
7802ef6 i386: split svm_helper into sysemu and stub-only user
205f16f i386: separate fpu_helper sysemu-only parts
aa80e42 i386: split misc helper user stubs and sysemu part
e8f8ed2 i386: move TCG bpt_helper into sysemu/
142ab958 i386: split tcg excp_helper into sysemu and user parts
ff581ca i386: split smm helper (sysemu)
509d8ba i386: split off sysemu-only functionality in tcg-cpu
247ca58 accel-cpu: make cpu_realizefn return a bool
89b9a03 target/i386: fix host_cpu_adjust_phys_bits error handling
3845cbd accel: introduce new accessor functions
f466cc0 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
34dd642 i386: split cpu accelerators from cpu.c, using AccelCPUClass
e418ab4 target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor
d191c6d target/i386: Rename helper_fldt, helper_fstt

=== OUTPUT BEGIN ===
1/33 Checking commit d191c6da5374 (target/i386: Rename helper_fldt, helper_fstt)
2/33 Checking commit e418ab44d351 (target/i386: Split out do_fsave, do_frstor, 
do_fxsave, do_fxrstor)
3/33 Checking commit 34dd6425b115 (i386: split cpu accelerators from cpu.c, 
using AccelCPUClass)
WARNING: line over 80 characters
#1337: FILE: target/i386/tcg/tcg-cpu.c:125:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 
0);

total: 0 errors, 1 warnings, 1249 lines checked

Patch 3/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/33 Checking commit f466cc007ae9 (cpu: call AccelCPUClass::cpu_realizefn in 
cpu_exec_realizefn)
5/33 Checking commit 3845cbd66375 (accel: introduce new accessor functions)
6/33 Checking commit 89b9a03dc7b9 (target/i386: fix host_cpu_adjust_phys_bits 
error handling)
7/33 Checking commit 247ca58bfdbd (accel-cpu: make cpu_realizefn return a bool)
8/33 Checking commit 509d8ba47db6 (i386: split off sysemu-only functionality in 
tcg-cpu)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

WARNING: line over 80 characters
#136: FILE: target/i386/tcg/sysemu/tcg-cpu.c:72:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 
0);

total: 0 errors, 2 warnings, 223 lines checked

Patch 8/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/33 Checking commit ff581ca3760f (i386: split smm helper (sysemu))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
 target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++-----------------

total: 0 errors, 1 warnings, 84 lines checked

Patch 9/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/33 Checking commit 142ab958eba8 (i386: split tcg excp_helper into sysemu and 
user parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#607: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#765: FILE: target/i386/tcg/sysemu/excp_helper.c:154:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is 
reserved.

WARNING: Block comments use a leading /* on a separate line
#839: FILE: target/i386/tcg/sysemu/excp_helper.c:228:
+/* return value:

WARNING: line over 80 characters
#940: FILE: target/i386/tcg/sysemu/excp_helper.c:329:
+            pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) 
<< 3)) &

WARNING: Block comments use a leading /* on a separate line
#1034: FILE: target/i386/tcg/sysemu/excp_helper.c:423:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is 
reserved.

WARNING: Block comments use a leading /* on a separate line
#1129: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+        /* only set write access if already dirty... otherwise wait

WARNING: Block comments use * on subsequent lines
#1130: FILE: target/i386/tcg/sysemu/excp_helper.c:519:
+        /* only set write access if already dirty... otherwise wait
+           for dirty access */

WARNING: Block comments use a trailing */ on a separate line
#1130: FILE: target/i386/tcg/sysemu/excp_helper.c:519:
+           for dirty access */

WARNING: Block comments use a leading /* on a separate line
#1143: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to

WARNING: Block comments use * on subsequent lines
#1144: FILE: target/i386/tcg/sysemu/excp_helper.c:533:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to
+       avoid filling it too fast */

WARNING: Block comments use a trailing */ on a separate line
#1144: FILE: target/i386/tcg/sysemu/excp_helper.c:533:
+       avoid filling it too fast */

ERROR: braces {} are necessary for all arms of this statement
#1158: FILE: target/i386/tcg/sysemu/excp_helper.c:547:
+    if (is_user)
[...]

total: 1 errors, 11 warnings, 632 lines checked

Patch 10/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/33 Checking commit e8f8ed2330c0 (i386: move TCG bpt_helper into sysemu/)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#366: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#502: FILE: target/i386/tcg/sysemu/bpt_helper.c:132:
+    /* If nothing is changing except the global/local enable bits,

WARNING: Block comments use * on subsequent lines
#503: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+    /* If nothing is changing except the global/local enable bits,
+       then we can make the change more efficient.  */

WARNING: Block comments use a trailing */ on a separate line
#503: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+       then we can make the change more efficient.  */

WARNING: Block comments use a leading /* on a separate line
#505: FILE: target/i386/tcg/sysemu/bpt_helper.c:135:
+        /* Fold the global and local enable bits together into the

WARNING: Block comments use * on subsequent lines
#506: FILE: target/i386/tcg/sysemu/bpt_helper.c:136:
+        /* Fold the global and local enable bits together into the
+           global fields, then xor to show which registers have

WARNING: Block comments use a trailing */ on a separate line
#507: FILE: target/i386/tcg/sysemu/bpt_helper.c:137:
+           changed collective enable state.  */

total: 0 errors, 7 warnings, 628 lines checked

Patch 11/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/33 Checking commit aa80e4256955 (i386: split misc helper user stubs and 
sysemu part)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#538: 
new file mode 100644

ERROR: switch and case should be at the same indent
#835: FILE: target/i386/tcg/sysemu/misc_helper.c:293:
+    switch ((uint32_t)env->regs[R_ECX]) {
[...]
+     case MSR_IA32_UCODE_REV:

total: 1 errors, 1 warnings, 1020 lines checked

Patch 12/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/33 Checking commit 205f16fd06d3 (i386: separate fpu_helper sysemu-only parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#110: 
new file mode 100644

total: 0 errors, 1 warnings, 135 lines checked

Patch 13/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/33 Checking commit 7802ef6d40e9 (i386: split svm_helper into sysemu and 
stub-only user)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
 target/i386/tcg/{ => sysemu}/svm_helper.c | 62 +------------------------

total: 0 errors, 1 warnings, 169 lines checked

Patch 14/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/33 Checking commit f80829b357df (i386: split seg_helper into user-only and 
sysemu parts)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#328: 
new file mode 100644

ERROR: do not use C99 // comments
#355: FILE: target/i386/tcg/seg_helper.h:23:
+//#define DEBUG_PCALL

WARNING: Block comments use a leading /* on a separate line
#628: FILE: target/i386/tcg/user/seg_helper.c:73:
+    /* Since we emulate only user space, we cannot do more than

WARNING: Block comments use * on subsequent lines
#629: FILE: target/i386/tcg/user/seg_helper.c:74:
+    /* Since we emulate only user space, we cannot do more than
+       exiting the emulation with the suitable exception and error

WARNING: Block comments use a trailing */ on a separate line
#630: FILE: target/i386/tcg/user/seg_helper.c:75:
+       code. So update EIP for INT 0x80 and EXCP_SYSCALL. */

WARNING: Block comments use a leading /* on a separate line
#641: FILE: target/i386/tcg/user/seg_helper.c:86:
+    /* if user mode only, we simulate a fake exception

WARNING: Block comments use * on subsequent lines
#642: FILE: target/i386/tcg/user/seg_helper.c:87:
+    /* if user mode only, we simulate a fake exception
+       which will be handled outside the cpu execution

WARNING: Block comments use a trailing */ on a separate line
#643: FILE: target/i386/tcg/user/seg_helper.c:88:
+       loop */

total: 1 errors, 7 warnings, 595 lines checked

Patch 15/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/33 Checking commit 92bc08007a75 (i386: split off sysemu part of cpu.c)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#54: FILE: target/i386/cpu-internal.h:30:
+    /* feature flags names are taken from "Intel Processor Identification and

WARNING: Block comments use a leading /* on a separate line
#137: FILE: target/i386/cpu-sysemu.c:37:
+/* Return a QDict containing keys for all properties that can be included

WARNING: Block comments use a leading /* on a separate line
#190: FILE: target/i386/cpu-sysemu.c:90:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#204: FILE: target/i386/cpu-sysemu.c:104:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#220: FILE: target/i386/cpu-sysemu.c:120:
+        /* "hotplugged" is the only property that is configurable

WARNING: Block comments use a leading /* on a separate line
#310: FILE: target/i386/cpu-sysemu.c:210:
+        /* As we don't return every single property, full expansion needs

total: 0 errors, 7 warnings, 901 lines checked

Patch 16/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/33 Checking commit cac1ed00200d (target/i386: gdbstub: introduce aux 
functions to read/write CS64 regs)
WARNING: line over 80 characters
#64: FILE: target/i386/gdbstub.c:163:
+            return gdb_read_reg_cs64(env->hflags, mem_buf, 
env->segs[R_FS].base);

WARNING: line over 80 characters
#70: FILE: target/i386/gdbstub.c:165:
+            return gdb_read_reg_cs64(env->hflags, mem_buf, 
env->segs[R_GS].base);

WARNING: line over 80 characters
#158: FILE: target/i386/gdbstub.c:318:
+            return gdb_write_reg_cs64(env->hflags, mem_buf, 
&env->segs[R_FS].base);

WARNING: line over 80 characters
#167: FILE: target/i386/gdbstub.c:320:
+            return gdb_write_reg_cs64(env->hflags, mem_buf, 
&env->segs[R_GS].base);

total: 0 errors, 4 warnings, 221 lines checked

Patch 17/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/33 Checking commit 8e1f9eb9ca5e (target/i386: gdbstub: only write 
CR0/CR2/CR3/EFER for sysemu)
19/33 Checking commit 95d93188b54e (i386: make cpu_load_efer sysemu-only)
20/33 Checking commit a68180fac1ba (accel: move call to accel_init_interfaces)
21/33 Checking commit e6027a1524d1 (accel: add init_accel_cpu for adapting 
accel behavior to CPU type)
22/33 Checking commit e158c09d46e9 (target/i386: merge SVM_NPTEXIT_* with 
PF_ERROR_* constants)
23/33 Checking commit 82189ebbef8b (target/i386: move paging mode constants 
from SVM to cpu.h)
24/33 Checking commit 1d5c83360ef4 (target/i386: extract mmu_translate)
ERROR: code indent should never use tabs
#204: FILE: target/i386/tcg/sysemu/excp_helper.c:539:
+^I  (env->cr[4] & CR4_PAE_MASK)) ||$

WARNING: Block comments use a leading /* on a separate line
#215: FILE: target/i386/tcg/sysemu/excp_helper.c:545:
+/* return value:

WARNING: line over 80 characters
#231: FILE: target/i386/tcg/sysemu/excp_helper.c:561:
+    printf("MMU fault: addr=%" VADDR_PRIx " w=%d mmu=%d eip=" TARGET_FMT_lx 
"\n",

WARNING: Block comments use a leading /* on a separate line
#253: FILE: target/i386/tcg/sysemu/excp_helper.c:582:
+        /* Even if 4MB pages, we map only one 4KB page in the cache to

WARNING: Block comments use * on subsequent lines
#254: FILE: target/i386/tcg/sysemu/excp_helper.c:583:
+        /* Even if 4MB pages, we map only one 4KB page in the cache to
+           avoid filling it too fast */

WARNING: Block comments use a trailing */ on a separate line
#254: FILE: target/i386/tcg/sysemu/excp_helper.c:583:
+           avoid filling it too fast */

total: 1 errors, 5 warnings, 248 lines checked

Patch 24/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

25/33 Checking commit e73fad8dedfc (target/i386: pass cr3 to mmu_translate)
26/33 Checking commit b41eebf2958c (target/i386: extend pg_mode to more CR0 and 
CR4 bits)
27/33 Checking commit fbfc2e7057f2 (target/i386: allow customizing the next 
phase of the translation)
WARNING: line over 80 characters
#22: FILE: target/i386/tcg/sysemu/excp_helper.c:263:
+typedef hwaddr (*MMUTranslateFunc)(CPUState *cs, hwaddr gphys, MMUAccessType 
access_type,

ERROR: code indent should never use tabs
#23: FILE: target/i386/tcg/sysemu/excp_helper.c:264:
+^I^I^I^Iint *prot);$

ERROR: code indent should never use tabs
#26: FILE: target/i386/tcg/sysemu/excp_helper.c:267:
+^I(get_hphys_func ? get_hphys_func(cs, gpa, access_type, prot) : gpa)$

WARNING: line over 80 characters
#28: FILE: target/i386/tcg/sysemu/excp_helper.c:269:
+static int mmu_translate(CPUState *cs, vaddr addr, MMUTranslateFunc 
get_hphys_func,

total: 2 errors, 2 warnings, 102 lines checked

Patch 27/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

28/33 Checking commit fab0cca38dbf (target/i386: use mmu_translate for NPT walk)
WARNING: line over 80 characters
#237: FILE: target/i386/tcg/sysemu/excp_helper.c:65:
+static int mmu_translate(CPUState *cs, hwaddr addr, MMUTranslateFunc 
get_hphys_func,

total: 0 errors, 1 warnings, 268 lines checked

Patch 28/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/33 Checking commit 314ce2200b5a (main-loop: remove dead code)
30/33 Checking commit fa0a3a00084a (migration: do not restart VM after 
successful snapshot-load)
31/33 Checking commit 72d3908a924f (qemu-option: support accept-any 
QemuOptsList in qemu_opts_absorb_qdict)
32/33 Checking commit 8c04d1df1780 (configure: fix detection of gdbus-codegen)
33/33 Checking commit 11165dcc3958 (coverity-scan: list components, move model 
to scripts/coverity-scan)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
 .../{coverity-model.c => coverity-scan/model.c}    |   0

total: 0 errors, 1 warnings, 154 lines checked

Patch 33/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210511081350.419428-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210511081350.419428-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com