[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] usb/mtp: avoid dynamic stack allocation
From: |
Gerd Hoffmann |
Subject: |
[PULL 5/6] usb/mtp: avoid dynamic stack allocation |
Date: |
Wed, 5 May 2021 15:07:15 +0200 |
Use autofree heap allocation instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-4-kraxel@redhat.com>
---
hw/usb/dev-mtp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index bbb827434482..2a895a73b083 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -907,7 +907,8 @@ static MTPData *usb_mtp_get_object_handles(MTPState *s,
MTPControl *c,
MTPObject *o)
{
MTPData *d = usb_mtp_data_alloc(c);
- uint32_t i = 0, handles[o->nchildren];
+ uint32_t i = 0;
+ g_autofree uint32_t *handles = g_new(uint32_t, o->nchildren);
MTPObject *iter;
trace_usb_mtp_op_get_object_handles(s->dev.addr, o->handle, o->path);
--
2.31.1
- [PULL 0/6] Usb 20210505 patches, Gerd Hoffmann, 2021/05/05
- [PULL 1/6] hw/usb/host-stub: Remove unused header, Gerd Hoffmann, 2021/05/05
- [PULL 3/6] usb/hid: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/05
- [PULL 2/6] hw/usb: Do not build USB subsystem if not required, Gerd Hoffmann, 2021/05/05
- [PULL 4/6] usb/redir: avoid dynamic stack allocation (CVE-2021-3527), Gerd Hoffmann, 2021/05/05
- [PULL 6/6] usb: limit combined packets to 1 MiB (CVE-2021-3527), Gerd Hoffmann, 2021/05/05
- [PULL 5/6] usb/mtp: avoid dynamic stack allocation,
Gerd Hoffmann <=
- Re: [PULL 0/6] Usb 20210505 patches, Peter Maydell, 2021/05/11