[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/6] usb/hid: avoid dynamic stack allocation
From: |
Gerd Hoffmann |
Subject: |
[PULL 3/6] usb/hid: avoid dynamic stack allocation |
Date: |
Wed, 5 May 2021 15:07:13 +0200 |
Use autofree heap allocation instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-2-kraxel@redhat.com>
---
hw/usb/dev-hid.c | 2 +-
hw/usb/dev-wacom.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index fc39bab79f94..1c7ae97c3033 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -656,7 +656,7 @@ static void usb_hid_handle_data(USBDevice *dev, USBPacket
*p)
{
USBHIDState *us = USB_HID(dev);
HIDState *hs = &us->hid;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
index b59504863509..ed687bc9f1eb 100644
--- a/hw/usb/dev-wacom.c
+++ b/hw/usb/dev-wacom.c
@@ -301,7 +301,7 @@ static void usb_wacom_handle_control(USBDevice *dev,
USBPacket *p,
static void usb_wacom_handle_data(USBDevice *dev, USBPacket *p)
{
USBWacomState *s = (USBWacomState *) dev;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
--
2.31.1
- [PULL 0/6] Usb 20210505 patches, Gerd Hoffmann, 2021/05/05
- [PULL 1/6] hw/usb/host-stub: Remove unused header, Gerd Hoffmann, 2021/05/05
- [PULL 3/6] usb/hid: avoid dynamic stack allocation,
Gerd Hoffmann <=
- [PULL 2/6] hw/usb: Do not build USB subsystem if not required, Gerd Hoffmann, 2021/05/05
- [PULL 4/6] usb/redir: avoid dynamic stack allocation (CVE-2021-3527), Gerd Hoffmann, 2021/05/05
- [PULL 6/6] usb: limit combined packets to 1 MiB (CVE-2021-3527), Gerd Hoffmann, 2021/05/05
- [PULL 5/6] usb/mtp: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/05
- Re: [PULL 0/6] Usb 20210505 patches, Peter Maydell, 2021/05/11