Re: QEMU tests, Coverity, and g_test_set_nonfatal_assertions()

[Richard Henderson]

On 5/3/21 9:49 AM, Peter Maydell wrote:
> (1) Expand "assertions always fatal" to test code, and add "panics"
> models of the g_assertion_message* functions. Remove all the calls
> to g_test_set_nonfatal_assertions().

I vaguely prefer this.  To me, "assert" means can't continue.

If we want tests that report and continue, we should use something else. 
Though of course could mean quite a bit of churn.


r~


> (2) Aim to expand the ability to use g_test_set_nonfatal_assertions()
> to other tests than the handful that currently use it (perhaps by
> providing a standard place where it gets called for all tests, though
> there isn't currently an obvious place to do that). Treat Coverity
> issues in our test code which flag up "this would crash if the
> assertion fired but execution continued" as bugs to be fixed (though
> not very high-priority ones, obviously).
>
> (3) Something else ?
>
> I think I vaguely favour 2, though it is of course more work...
> In any case, we need to make a decision so we can decide whether
> the pile of coverity issues should be either dismissed as intentional
> or gradually worked through and fixed.
>
> thanks
> -- PMM