[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] tests: Avoid side effects inside g_assert() arguments
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 3/3] tests: Avoid side effects inside g_assert() arguments |
|
Date: |
Mon, 3 May 2021 19:14:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 6:55 PM, Peter Maydell wrote:
> For us, assertions are always enabled, but side-effect expressions
> inside the argument to g_assert() are bad style anyway. Fix three
> occurrences in IPMI related tests, which will silence some Coverity
> nits.
>
> Fixes: CID 1432322, CID 1432287, CID 1432291
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> tests/qtest/ipmi-bt-test.c | 6 ++++--
> tests/qtest/ipmi-kcs-test.c | 3 ++-
> 2 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>