Re: [RFC PATCH 4/8] qtest/fuzz: Restrict CPU I/O instructions

[Paolo Bonzini]

On 15/03/21 06:14, Thomas Huth wrote:
> > diff --git a/tests/qtest/fuzz/generic_fuzz.c 
> > b/tests/qtest/fuzz/generic_fuzz.c
> > index ee8c17a04c4..3e0089f4a63 100644
> > --- a/tests/qtest/fuzz/generic_fuzz.c
> > +++ b/tests/qtest/fuzz/generic_fuzz.c
> > @@ -304,6 +304,13 @@ static bool get_io_address(address_range *result, 
> > AddressSpace *as,
> >       return cb_info.found;
> >   }
> > +static bool get_mmio_address(address_range *result,
> > +                             uint8_t index, uint32_t offset)
> > +{
> > +    return get_io_address(result, &address_space_memory, index, offset);
> > +}
> > +
> > +#ifdef TARGET_HAS_IOPORT
>
> Sorry, but the qtests are generic code, I don't think we should 
> introduce target specific ifdefs here...?

FWIW this is not a qtest, it's a separate emulator executable and this 
file is compiled per-target.

That said, your objection does apply to patch 5 since libqos is compiled 
only once for all targets.

Paolo