Re: [PATCH 0/2] More qemu_strtosz fixes

[no-reply]

Patchew URL: 
20210317143325.2165821-1-eblake@redhat.com/">https://patchew.org/QEMU/20210317143325.2165821-1-eblake@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210317143325.2165821-1-eblake@redhat.com
Subject: [PATCH 0/2] More qemu_strtosz fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   5d1428d..25a7751  master     -> master
 - [tag update]      patchew/20210315230838.2973103-1-f4bug@amsat.org -> 
patchew/20210315230838.2973103-1-f4bug@amsat.org
 - [tag update]      patchew/20210315233527.2988483-1-philmd@redhat.com -> 
patchew/20210315233527.2988483-1-philmd@redhat.com
 - [tag update]      
patchew/20210316220735.2048137-1-richard.henderson@linaro.org -> 
patchew/20210316220735.2048137-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210317143325.2165821-1-eblake@redhat.com -> 
patchew/20210317143325.2165821-1-eblake@redhat.com
Switched to a new branch 'test'
36c9a8f utils: Work around mingw strto*l bug with 0x
81af63e utils: Tighter tests for qemu_strtosz

=== OUTPUT BEGIN ===
1/2 Checking commit 81af63e53841 (utils: Tighter tests for qemu_strtosz)
2/2 Checking commit 36c9a8f42010 (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#141: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210317143325.2165821-1-eblake@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210317143325.2165821-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com