[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP comm
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results |
Date: |
Mon, 15 Mar 2021 17:33:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 3/12/21 9:32 AM, Markus Armbruster wrote:
>> This policy suppresses deprecated bits in output, and thus permits
>> "testing the future". Implement it for QMP command results. Example:
>> when QEMU is run with -compat deprecated-output=hide, then
>>
>> {"execute": "query-cpus-fast"}
>>
>> yields
>>
>> {"return": [{"thread-id": 9805, "props": {"core-id": 0, "thread-id": 0,
>> "socket-id": 0}, "qom-path": "/machine/unattached/device[0]", "cpu-index":
>> 0, "target": "x86_64"}]}
>>
>> instead of
>>
>> {"return": [{"arch": "x86", "thread-id": 22436, "props": {"core-id": 0,
>> "thread-id": 0, "socket-id": 0}, "qom-path":
>> "/machine/unattached/device[0]", "cpu-index": 0, "target": "x86_64"}]}
>
> Example may not be relevant much longer, given Dan's patch [1] to make
> this permanent since we've already passed the deprecation wait. Up to
> you if you want to choose a different example.
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07564.html
I think I'll keep this one just to save me some time. Even a slightly
outdated example should serve okay as illustration.
>
>>
>> Note the suppression of deprecated member "arch".
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>
> R-b still stands.
Thanks!
- [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/12
- [PATCH v6 01/10] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2021/03/12
- [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2021/03/12
- [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2021/03/12
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2021/03/12
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12
- [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2021/03/12