Re: [PATCH v6 10/10] qapi: New -compat deprecated-input=crash

[Eric Blake]

On 3/12/21 9:32 AM, Markus Armbruster wrote:
> Policy "crash" calls abort() when deprecated input is received.
> 
> Bugs in integration tests may mask the error from policy "reject".
> Provide a larger hammer: crash outright.  Masking that seems unlikely.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  qapi/compat.json             | 9 +++++----
>  qapi/qmp-dispatch.c          | 1 +
>  qapi/qobject-input-visitor.c | 1 +
>  qemu-options.hx              | 4 +++-
>  4 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/qapi/compat.json b/qapi/compat.json
> index d2c02a21aa..ae3afc22df 100644
> --- a/qapi/compat.json
> +++ b/qapi/compat.json
> @@ -11,11 +11,12 @@
>  #
>  # @accept: Accept silently
>  # @reject: Reject with an error
> +# @crash: abort() the process
>  #
> -# Since: 5.2
> +# Since: 6.0

Rebase churn once you fix this earlier in the series.

R-b still stands.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org