[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/mips: Use gen_load_gpr[_hi]() when possible
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] target/mips: Use gen_load_gpr[_hi]() when possible |
|
Date: |
Tue, 9 Mar 2021 15:49:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/8/21 2:16 PM, Philippe Mathieu-Daudé wrote:
> Use gen_load_gpr[_hi]() instead of open coding it.
>
> Patch generated using the following spatch script:
>
> @gen_load_gpr@
> identifier reg_idx;
> expression tcg_reg;
> @@
> -if (reg_idx == 0) {
> - tcg_gen_movi_tl(tcg_reg, 0);
> -} else {
> - tcg_gen_mov_tl(tcg_reg, cpu_gpr[reg_idx]);
> -}
> +gen_load_gpr(tcg_reg, reg_idx);
>
> @gen_load_gpr_hi@
> identifier reg_idx;
> expression tcg_reg;
> @@
> -if (reg_idx == 0) {
> - tcg_gen_movi_i64(tcg_reg, 0);
> -} else {
> - tcg_gen_mov_i64(tcg_reg, cpu_gpr_hi[reg_idx]);
> -}
> +gen_load_gpr_hi(tcg_reg, reg_idx);
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.c | 29 ++++++-----------------------
> 1 file changed, 6 insertions(+), 23 deletions(-)
Thanks, applied to mips-next.