Re: [PATCH] target/mips: Use gen_load_gpr[_hi]() when possible

[Richard Henderson]

On 3/8/21 5:16 AM, Philippe Mathieu-Daudé wrote:
> Use gen_load_gpr[_hi]() instead of open coding it.
>
> Patch generated using the following spatch script:
>
>    @gen_load_gpr@
>    identifier reg_idx;
>    expression tcg_reg;
>    @@
>    -if (reg_idx == 0) {
>    -    tcg_gen_movi_tl(tcg_reg, 0);
>    -} else {
>    -    tcg_gen_mov_tl(tcg_reg, cpu_gpr[reg_idx]);
>    -}
>    +gen_load_gpr(tcg_reg, reg_idx);
>
>    @gen_load_gpr_hi@
>    identifier reg_idx;
>    expression tcg_reg;
>    @@
>    -if (reg_idx == 0) {
>    -    tcg_gen_movi_i64(tcg_reg, 0);
>    -} else {
>    -    tcg_gen_mov_i64(tcg_reg, cpu_gpr_hi[reg_idx]);
>    -}
>    +gen_load_gpr_hi(tcg_reg, reg_idx);
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~