[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr
From: |
Claudio Fontana |
Subject: |
Re: [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr |
Date: |
Tue, 2 Mar 2021 13:16:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 3/2/21 5:35 AM, Richard Henderson wrote:
> On 3/1/21 8:49 AM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana<cfontana@suse.de>
>> ---
>> target/arm/get-phys-addr.c | 95 ++++++++++++++++++++++++++++++++++++++
>> target/arm/tcg/helper.c | 95 --------------------------------------
>> 2 files changed, 95 insertions(+), 95 deletions(-)
>
> So... get-phys-addr.c is now gaining stuff not related to get_phys_addr?
> What's your end goal?
>
> Is there a better a better name, like mmu_helper.c? Should these in fact go
> into a second file, leaving get-phys-addr to itself?
>
>
> r~
>
These are all good questions;
I would like to avoid the word "helper", as it triggers tcg/ HELPER() stuff for
me,
but I am not excluding it if we don't have a better idea.
The alternative to put this stuff into their own file is open for me.
Thanks,
Claudio