qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr


From: Richard Henderson
Subject: Re: [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr
Date: Mon, 1 Mar 2021 20:35:41 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/1/21 8:49 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana<cfontana@suse.de>
---
  target/arm/get-phys-addr.c | 95 ++++++++++++++++++++++++++++++++++++++
  target/arm/tcg/helper.c    | 95 --------------------------------------
  2 files changed, 95 insertions(+), 95 deletions(-)

So... get-phys-addr.c is now gaining stuff not related to get_phys_addr? What's your end goal?

Is there a better a better name, like mmu_helper.c? Should these in fact go into a second file, leaving get-phys-addr to itself?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]