[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size
|
From: |
chen huacai |
|
Subject: |
Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size |
|
Date: |
Thu, 29 Oct 2020 07:10:59 +0000 |
Hi, Richard,
On Wed, Oct 28, 2020 at 4:48 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/27/20 9:17 PM, Huacai Chen wrote:
> > +invalid:
> > + /*
> > + * When invalid, ensure the value is bigger than or equal to
> > + * the minimal but smaller than or equal to the maxium.
> > + */
> > + maskbits = MIN(16, MAX(maskbits, TARGET_PAGE_BITS - 12));
> > + env->CP0_PageMask = ((1 << (16 + 1)) - 1) << CP0PM_MASK;
>
> maskbits is unused. Did you mean to use it?
This is redundant, will be removed.
Huacai
>
>
> r~
--
Huacai Chen
- [PATCH V15 0/6] mips: Add Loongson-3 machine support, Huacai Chen, 2020/10/28
- [PATCH V15 1/6] target/mips: Fix PageMask with variable page size, Huacai Chen, 2020/10/28
- [PATCH V15 2/6] target/mips: Add unaligned access support for MIPS64R6 and Loongson-3, Huacai Chen, 2020/10/28
- [PATCH V15 3/6] hw/mips: Implement fw_cfg_arch_key_name(), Huacai Chen, 2020/10/28
- [PATCH V15 4/6] hw/mips: Add Loongson-3 boot parameter helpers, Huacai Chen, 2020/10/28
- [PATCH V15 5/6] hw/mips: Add Loongson-3 machine support, Huacai Chen, 2020/10/28
- [PATCH V15 6/6] docs/system: Update MIPS machine documentation, Huacai Chen, 2020/10/28