[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size |
|
Date: |
Wed, 28 Oct 2020 09:48:14 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/27/20 9:17 PM, Huacai Chen wrote:
> +invalid:
> + /*
> + * When invalid, ensure the value is bigger than or equal to
> + * the minimal but smaller than or equal to the maxium.
> + */
> + maskbits = MIN(16, MAX(maskbits, TARGET_PAGE_BITS - 12));
> + env->CP0_PageMask = ((1 << (16 + 1)) - 1) << CP0PM_MASK;
maskbits is unused. Did you mean to use it?
r~
- [PATCH V15 0/6] mips: Add Loongson-3 machine support, Huacai Chen, 2020/10/28
- [PATCH V15 1/6] target/mips: Fix PageMask with variable page size, Huacai Chen, 2020/10/28
- Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size,
Richard Henderson <=
- [PATCH V15 2/6] target/mips: Add unaligned access support for MIPS64R6 and Loongson-3, Huacai Chen, 2020/10/28
- [PATCH V15 3/6] hw/mips: Implement fw_cfg_arch_key_name(), Huacai Chen, 2020/10/28
- [PATCH V15 4/6] hw/mips: Add Loongson-3 boot parameter helpers, Huacai Chen, 2020/10/28
- [PATCH V15 5/6] hw/mips: Add Loongson-3 machine support, Huacai Chen, 2020/10/28
- [PATCH V15 6/6] docs/system: Update MIPS machine documentation, Huacai Chen, 2020/10/28