[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/36] qdev: Avoid unnecessary DeviceState* variable at set_prop_
From: |
Eduardo Habkost |
Subject: |
[PATCH 18/36] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() |
Date: |
Thu, 29 Oct 2020 18:02:28 -0400 |
We're just doing pointer math with the device pointer, we can
simply use obj instead.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 68b1666e14..27c09255d7 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -610,10 +610,9 @@ static void set_prop_arraylen(Object *obj, Visitor *v,
const char *name,
* array-length field in the device struct, we have to create the
* array itself and dynamically add the corresponding properties.
*/
- DeviceState *dev = DEVICE(obj);
Property *prop = opaque;
uint32_t *alenptr = qdev_get_prop_ptr(obj, prop);
- void **arrayptr = (void *)dev + prop->arrayoffset;
+ void **arrayptr = (void *)obj + prop->arrayoffset;
void *eltptr;
const char *arrayname;
int i;
@@ -653,7 +652,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v,
const char *name,
* they get the right answer despite the array element not actually
* being inside the device struct.
*/
- arrayprop->prop.offset = eltptr - (void *)dev;
+ arrayprop->prop.offset = eltptr - (void *)obj;
assert(qdev_get_prop_ptr(obj, &arrayprop->prop) == eltptr);
object_property_add(obj, propname,
arrayprop->prop.info->name,
--
2.28.0
[PATCH 20/36] qdev: Reuse object_property_add_static() when adding array elements, Eduardo Habkost, 2020/10/29
[PATCH 21/36] qom: Add allow_set callback to ObjectProperty, Eduardo Habkost, 2020/10/29
[PATCH 14/36] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/10/29
[PATCH 18/36] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(),
Eduardo Habkost <=
[PATCH 22/36] qdev: Make qdev_prop_allow_set() a property allow_set callback, Eduardo Habkost, 2020/10/29
[PATCH 24/36] qdev: Rename qdev_propinfo_* to object_propinfo_*, Eduardo Habkost, 2020/10/29
[PATCH 23/36] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/10/29
[PATCH 26/36] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/10/29
[PATCH 31/36] qdev: Stop using error_set_from_qdev_prop_error() for UUID property, Eduardo Habkost, 2020/10/29