[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 21/36] qom: Add allow_set callback to ObjectProperty
From: |
Eduardo Habkost |
Subject: |
[PATCH 21/36] qom: Add allow_set callback to ObjectProperty |
Date: |
Thu, 29 Oct 2020 18:02:31 -0400 |
Note that this doesn't replace the check callback at
object*_property_add_link() (yet), because currently the link
property check callback needs to get the property value as
argument (despite this not being necessary in most cases).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
include/qom/object.h | 16 ++++++++++++++++
qom/object.c | 4 ++++
2 files changed, 20 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index d378f13a11..24e591d954 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -86,6 +86,21 @@ typedef void (ObjectPropertyRelease)(Object *obj,
*/
typedef void (ObjectPropertyInit)(Object *obj, ObjectProperty *prop);
+/**
+ * typedef ObjectPropertyAllowSet:
+ * @obj: the object that owns the property
+ * @prop: the property being set
+ * @errp: pointer to error information
+ *
+ * Called when a property is being set.
+ *
+ * If return value is false, it will prevent the property from
+ * being changed. Error information should be filled in @errp
+ * if return vlaue is false.
+ */
+typedef bool (ObjectPropertyAllowSet)(Object *obj, ObjectProperty *prop,
+ Error **errp);
+
struct ObjectProperty
{
char *name;
@@ -96,6 +111,7 @@ struct ObjectProperty
ObjectPropertyResolve *resolve;
ObjectPropertyRelease *release;
ObjectPropertyInit *init;
+ ObjectPropertyAllowSet *allow_set;
void *opaque;
QObject *defval;
};
diff --git a/qom/object.c b/qom/object.c
index 1065355233..20726e4584 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1395,6 +1395,10 @@ bool object_property_set(Object *obj, const char *name,
Visitor *v,
error_setg(errp, QERR_PERMISSION_DENIED);
return false;
}
+ if (prop->allow_set && !prop->allow_set(obj, prop, errp)) {
+ return false;
+ }
+
prop->set(obj, v, name, prop->opaque, &err);
error_propagate(errp, err);
return !err;
--
2.28.0
- Re: [PATCH 16/36] qdev: Make qdev_class_add_property() more flexible, (continued)
- [PATCH 20/36] qdev: Reuse object_property_add_static() when adding array elements, Eduardo Habkost, 2020/10/29
- [PATCH 21/36] qom: Add allow_set callback to ObjectProperty,
Eduardo Habkost <=
- [PATCH 14/36] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/10/29
- [PATCH 18/36] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(), Eduardo Habkost, 2020/10/29
- [PATCH 22/36] qdev: Make qdev_prop_allow_set() a property allow_set callback, Eduardo Habkost, 2020/10/29
- [PATCH 24/36] qdev: Rename qdev_propinfo_* to object_propinfo_*, Eduardo Habkost, 2020/10/29