[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] test-util-sockets: Plug file descriptor leak
From: |
Eric Blake |
Subject: |
Re: [PATCH 01/11] test-util-sockets: Plug file descriptor leak |
Date: |
Thu, 29 Oct 2020 12:59:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:38 AM, Markus Armbruster wrote:
> Fixes: 4d3a329af59ef8acd076f99f05e82531d8129b34
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
Only a test bug, but a bug nonetheless, so appropriate for 5.2
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c
> index f6336e0f91..15da867b8f 100644
> --- a/tests/test-util-sockets.c
> +++ b/tests/test-util-sockets.c
> @@ -252,6 +252,7 @@ static gpointer unix_server_thread_func(gpointer
> user_data)
>
> connfd = accept(fd, (struct sockaddr *)&un, &len);
> g_assert_cmpint(connfd, !=, -1);
> + close(connfd);
>
> close(fd);
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 03/11] test-util-sockets: Clean up SocketAddress construction, (continued)
- [PATCH 03/11] test-util-sockets: Clean up SocketAddress construction, Markus Armbruster, 2020/10/29
- [PATCH 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one(), Markus Armbruster, 2020/10/29
- [PATCH 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, Markus Armbruster, 2020/10/29
- [PATCH 02/11] test-util-sockets: Correct to set has_abstract, has_tight, Markus Armbruster, 2020/10/29
- [PATCH 01/11] test-util-sockets: Plug file descriptor leak, Markus Armbruster, 2020/10/29
- Re: [PATCH 01/11] test-util-sockets: Plug file descriptor leak,
Eric Blake <=
- [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1), Markus Armbruster, 2020/10/29
- [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight, Markus Armbruster, 2020/10/29
- Re: [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight, Eric Blake, 2020/10/29
- [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/10/29