[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] test-util-sockets: Clean up SocketAddress construction
From: |
Eric Blake |
Subject: |
Re: [PATCH 03/11] test-util-sockets: Clean up SocketAddress construction |
Date: |
Thu, 29 Oct 2020 13:43:01 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:38 AM, Markus Armbruster wrote:
> The thread functions build the SocketAddress from global variable
> @abstract_sock_name and the tight flag passed as pointer
> argument (either NULL or (gpointer)1). There is no need for such
> hackery; simply pass the SocketAddress instead.
>
> While there, dumb down g_rand_int_range() to g_random_int().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-sockets.c | 62 +++++++++++++++------------------------
> 1 file changed, 24 insertions(+), 38 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org