qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/11] target/arm: Add read/write_neon_element32


From: Peter Maydell
Subject: Re: [PATCH 05/11] target/arm: Add read/write_neon_element32
Date: Thu, 29 Oct 2020 10:15:04 +0000

On Wed, 28 Oct 2020 at 20:23, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/27/20 8:26 PM, Richard Henderson wrote:
> > @@ -3871,24 +3923,26 @@ static bool trans_VTRN(DisasContext *s, arg_2misc 
> > *a)
> >          return true;
> >      }
> >
> > -    if (a->size == 2) {
> > +    tmp = tcg_temp_new_i32();
> > +    tmp2 = tcg_temp_new_i32();
> > +    if (a->size == MO_32) {
> ...
> >      }
> >      return true;
>
> Bah, forgot to free these temps.  Did I configure my first round of testing
> without debug enabled?

Oops, I forgot to run the find-leak-warnings command in my setup.
As well as this one in VTRN, it also reports an issue with VREV.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]