[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] target/arm: Add read/write_neon_element32
From: |
Peter Maydell |
Subject: |
Re: [PATCH 05/11] target/arm: Add read/write_neon_element32 |
Date: |
Thu, 29 Oct 2020 10:15:04 +0000 |
On Wed, 28 Oct 2020 at 20:23, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/27/20 8:26 PM, Richard Henderson wrote:
> > @@ -3871,24 +3923,26 @@ static bool trans_VTRN(DisasContext *s, arg_2misc
> > *a)
> > return true;
> > }
> >
> > - if (a->size == 2) {
> > + tmp = tcg_temp_new_i32();
> > + tmp2 = tcg_temp_new_i32();
> > + if (a->size == MO_32) {
> ...
> > }
> > return true;
>
> Bah, forgot to free these temps. Did I configure my first round of testing
> without debug enabled?
Oops, I forgot to run the find-leak-warnings command in my setup.
As well as this one in VTRN, it also reports an issue with VREV.
thanks
-- PMM
- [PATCH 00/11] target/arm: Fix neon reg offsets, Richard Henderson, 2020/10/27
- [PATCH 01/11] target/arm: Introduce neon_full_reg_offset, Richard Henderson, 2020/10/27
- [PATCH 02/11] target/arm: Move neon_element_offset to translate.c, Richard Henderson, 2020/10/27
- [PATCH 03/11] target/arm: Use neon_element_offset in neon_load/store_reg, Richard Henderson, 2020/10/27
- [PATCH 04/11] target/arm: Use neon_element_offset in vfp_reg_offset, Richard Henderson, 2020/10/27
- [PATCH 06/11] target/arm: Expand read/write_neon_element32 to all MemOp, Richard Henderson, 2020/10/27
- [PATCH 05/11] target/arm: Add read/write_neon_element32, Richard Henderson, 2020/10/27
- [PATCH 07/11] target/arm: Rename neon_load_reg32 to vfp_load_reg32, Richard Henderson, 2020/10/27
- [PATCH 08/11] target/arm: Add read/write_neon_element64, Richard Henderson, 2020/10/27
- [PATCH 09/11] target/arm: Rename neon_load_reg64 to vfp_load_reg64, Richard Henderson, 2020/10/27
- [PATCH 11/11] target/arm: Improve do_prewiden_3d, Richard Henderson, 2020/10/27
- [PATCH 10/11] target/arm: Simplify do_long_3d and do_2scalar_long, Richard Henderson, 2020/10/27
- Re: [PATCH 00/11] target/arm: Fix neon reg offsets, Peter Maydell, 2020/10/28
- Re: [PATCH 00/11] target/arm: Fix neon reg offsets, Peter Maydell, 2020/10/28