[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/11] target/arm: Use neon_element_offset in vfp_reg_offset
From: |
Richard Henderson |
Subject: |
[PATCH 04/11] target/arm: Use neon_element_offset in vfp_reg_offset |
Date: |
Tue, 27 Oct 2020 20:26:56 -0700 |
This seems a bit more readable than using offsetof CPU_DoubleU.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 88a926d1df..88ded4ac2c 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -1122,18 +1122,13 @@ static long neon_element_offset(int reg, int element,
MemOp size)
return neon_full_reg_offset(reg) + ofs;
}
-static inline long vfp_reg_offset(bool dp, unsigned reg)
+/* Return the offset of a VFP Dreg (dp = true) or VFP Sreg (dp = false). */
+static long vfp_reg_offset(bool dp, unsigned reg)
{
if (dp) {
- return offsetof(CPUARMState, vfp.zregs[reg >> 1].d[reg & 1]);
+ return neon_element_offset(reg, 0, MO_64);
} else {
- long ofs = offsetof(CPUARMState, vfp.zregs[reg >> 2].d[(reg >> 1) &
1]);
- if (reg & 1) {
- ofs += offsetof(CPU_DoubleU, l.upper);
- } else {
- ofs += offsetof(CPU_DoubleU, l.lower);
- }
- return ofs;
+ return neon_element_offset(reg >> 1, reg & 1, MO_32);
}
}
--
2.25.1
- [PATCH 00/11] target/arm: Fix neon reg offsets, Richard Henderson, 2020/10/27
- [PATCH 01/11] target/arm: Introduce neon_full_reg_offset, Richard Henderson, 2020/10/27
- [PATCH 02/11] target/arm: Move neon_element_offset to translate.c, Richard Henderson, 2020/10/27
- [PATCH 03/11] target/arm: Use neon_element_offset in neon_load/store_reg, Richard Henderson, 2020/10/27
- [PATCH 04/11] target/arm: Use neon_element_offset in vfp_reg_offset,
Richard Henderson <=
- [PATCH 06/11] target/arm: Expand read/write_neon_element32 to all MemOp, Richard Henderson, 2020/10/27
- [PATCH 05/11] target/arm: Add read/write_neon_element32, Richard Henderson, 2020/10/27
- [PATCH 07/11] target/arm: Rename neon_load_reg32 to vfp_load_reg32, Richard Henderson, 2020/10/27
- [PATCH 08/11] target/arm: Add read/write_neon_element64, Richard Henderson, 2020/10/27
- [PATCH 09/11] target/arm: Rename neon_load_reg64 to vfp_load_reg64, Richard Henderson, 2020/10/27
- [PATCH 11/11] target/arm: Improve do_prewiden_3d, Richard Henderson, 2020/10/27
- [PATCH 10/11] target/arm: Simplify do_long_3d and do_2scalar_long, Richard Henderson, 2020/10/27
- Re: [PATCH 00/11] target/arm: Fix neon reg offsets, Peter Maydell, 2020/10/28