Re: [PATCH v3 4/7] coroutine: add libucontext as external library

[Joelle van Dyne]

Mirroring the repo by QEMU is fine and preferred. Not sure if anything
is required from my end there.

slirp_opt slipped in from a rebase and should not be there, will fix.

-j

On Wed, Oct 28, 2020 at 4:48 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Tue, Oct 27, 2020 at 08:06:58PM -0700, Joelle van Dyne wrote:
>
> I am not a lawyer and haven't consulted any lawyers, but libucontext
> seems compatible with QEMU's license to me. I think QEMU can mirror the
> libucontext repo and ship it like the other submodules. No changes to
> QEMU's ./LICENSE are necessary since it is similar to the other
> permissive licenses already in use.
>
> FWIW I only took a look at
> https://github.com/utmapp/libucontext/blob/master/LICENSE. I did not
> review the actual libucontext source code.
>
> > diff --git a/meson.build b/meson.build
> > index 48c95150fe..0beb199303 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1243,9 +1243,35 @@ if not fdt.found() and fdt_required.length() > 0
> >    error('fdt not available but required by targets ' + ', 
> > '.join(fdt_required))
> >  endif
> >
> > +ucontext = not_found
> > +slirp_opt = 'disabled'
>
> Minor issue: the slirp_opt change should probably be part of another patch.