[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/7] configure: option to disable host block devices
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v3 1/7] configure: option to disable host block devices |
Date: |
Wed, 28 Oct 2020 11:22:00 +0000 |
On Tue, Oct 27, 2020 at 08:06:55PM -0700, Joelle van Dyne wrote:
> Some hosts (iOS) have a sandboxed filesystem and do not provide low-level
> APIs for interfacing with host block devices.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> configure | 4 ++++
> meson.build | 1 +
> block/file-posix.c | 8 +++++++-
> 3 files changed, 12 insertions(+), 1 deletion(-)
A change along these lines is needed in qapi/block-core.json:
{ 'enum': 'BlockdevDriver',
...
{ 'name': 'host_device', 'if': 'defined(CONFIG_HOST_BLOCK_DEVICE)' }
That way the QAPI schema reflects the QEMU binary's actual features.
>
> diff --git a/configure b/configure
> index 71bbe82ac5..4e68a5fefe 100755
> --- a/configure
> +++ b/configure
> @@ -448,6 +448,7 @@ ninja=""
> skip_meson=no
> gettext=""
> mirror_jit="no"
> +host_block_device_support="yes"
>
> bogus_os="no"
> malloc_trim="auto"
> @@ -5901,6 +5902,9 @@ if test "$default_devices" = "yes" ; then
> else
> echo "CONFIG_MINIKCONF_MODE=--allnoconfig" >> $config_host_mak
> fi
> +if test "$host_block_device_support" = "yes" ; then
> + echo "CONFIG_HOST_BLOCK_DEVICE=y" >> $config_host_mak
> +fi
> if test "$debug_tcg" = "yes" ; then
> echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak
> fi
How do you disable CONFIG_HOST_BLOCK_DEVICE? There is no ./configure
--disable-host-block-device option.
signature.asc
Description: PGP signature
[PATCH v3 5/7] slirp: update build flags for iOS resolv fix, Joelle van Dyne, 2020/10/27