qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci()
Date: Sat, 24 Oct 2020 21:52:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 
On 10/22/20 4:00 PM, Stefan Hajnoczi wrote:

On Tue, Oct 20, 2020 at 07:24:15PM +0200, Philippe Mathieu-Daudé wrote:

@@ -724,7 +725,7 @@ static int nvme_init(BlockDriverState *bs, const char 
*device, int namespace,
          goto out;
      }
- s->page_size = MAX(4096, 1u << (12 + NVME_CAP_MPSMIN(cap))); 
+    s->page_size = MAX(min_page_size, 1u << (12 + NVME_CAP_MPSMIN(cap)));


Is there a guarantee that the NVMe drive supports our min_page_size?


No, good point!



Stefan
reply via email to
[Prev in Thread] Current Thread [Next in Thread]