[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci() |
|
Date: |
Thu, 22 Oct 2020 15:00:50 +0100 |
On Tue, Oct 20, 2020 at 07:24:15PM +0200, Philippe Mathieu-Daudé wrote:
> @@ -724,7 +725,7 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
> goto out;
> }
>
> - s->page_size = MAX(4096, 1u << (12 + NVME_CAP_MPSMIN(cap)));
> + s->page_size = MAX(min_page_size, 1u << (12 + NVME_CAP_MPSMIN(cap)));
Is there a guarantee that the NVMe drive supports our min_page_size?
Stefan
signature.asc
Description: PGP signature
- [PATCH 00/16] util/vfio-helpers: Allow using multiple MSIX IRQs, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 01/16] block/nvme: Correct minimum device page size, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 02/16] util/vfio-helpers: Improve reporting unsupported IOMMU type, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci(), Philippe Mathieu-Daudé, 2020/10/20
- Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci(),
Stefan Hajnoczi <=
- [PATCH 04/16] util/vfio-helpers: Report error when IOMMU page size is not supported, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 05/16] util/vfio-helpers: Trace PCI I/O config accesses, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 06/16] util/vfio-helpers: Trace PCI BAR region info, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 07/16] util/vfio-helpers: Trace where BARs are mapped, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 08/16] util/vfio-helpers: Improve DMA trace events, Philippe Mathieu-Daudé, 2020/10/20