[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 0/3] Add Versal usb model
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH v12 0/3] Add Versal usb model |
Date: |
Fri, 23 Oct 2020 11:27:18 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Oct 22, 2020 at 05:47:33PM +0530, Sai Pavan Boddu wrote:
> This patch series attempts to make 'hcd-xhci' an independent model so it can
> be used by both pci and system-bus interface.
On the series:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Changes for V2:
> Make XHCIState non-qom
> Use container_of functions for retriving pci device instance
> Initialize the AddressSpace pointer in PATCH 1/3 itself Changes for V3:
> Convert XHCIState to TYPE_DEVICE and register as a child of XHCIPciState.
> Changes for V4:
> Add DWC3 usb controller
> Add versal, usb2-reg module
> Connect sysbus xhci to versal virt board Changes for V5:
> Add extra info about dwc3 and usb2_regs devices in commit messages
> Use only one irq for versal usb controller
> Mark the unimplemented registers in dwc3 controller
> Rebase the patches over master.
> Move few mispalced contents from patch 2/7 to 3/7.
> Fix the author names in the header.
> Move the inclusion of "sysemu/dma.h" from patch 1/7 to 3/7 Changes for V6:
> Fixed style issue in patch 7/7
> Renamed usb2_reg model to VersalUsb2CtrlReg
> Fixed author in headers
> Changes for V7:
> Create a usb structure to keep things clean
> Remove the repeated patch in the series i.e 5/7 Changes for V8:
> Fix vmstate sturcts to support cross version migration.
> Changes for V9:
> Added recommended changes to fix vmstate migration.
> Fixed commit message on 3/7.
> Changes for V10:
> use vmstate_post_load avaialble in VMStateDescription
> tested vmstate cross migration.
> Changes for V11:
> Removed the patches which got accepted
> Changed object name "USB2Reg" -> "ctrl"
> Updated Subject line on cover letter.
> Changes for V12:
> Use reset class for usb2-ctrl-regs module
> Move the few register update to realize
> Marked registers which are unimplemented in regapi model
>
>
> Sai Pavan Boddu (1):
> misc: Add versal-usb2-ctrl-regs module
>
> Vikram Garhwal (2):
> usb: Add DWC3 model
> Versal: Connect DWC3 controller with virt-versal
>
> hw/arm/xlnx-versal-virt.c | 58 +++
> hw/arm/xlnx-versal.c | 34 ++
> hw/misc/meson.build | 1 +
> hw/misc/xlnx-versal-usb2-ctrl-regs.c | 229 +++++++++
> hw/usb/Kconfig | 6 +
> hw/usb/hcd-dwc3.c | 666
> +++++++++++++++++++++++++++
> hw/usb/meson.build | 1 +
> include/hw/arm/xlnx-versal.h | 14 +
> include/hw/misc/xlnx-versal-usb2-ctrl-regs.h | 45 ++
> include/hw/usb/hcd-dwc3.h | 55 +++
> 10 files changed, 1109 insertions(+)
> create mode 100644 hw/misc/xlnx-versal-usb2-ctrl-regs.c
> create mode 100644 hw/usb/hcd-dwc3.c
> create mode 100644 include/hw/misc/xlnx-versal-usb2-ctrl-regs.h
> create mode 100644 include/hw/usb/hcd-dwc3.h
>
> --
> 2.7.4
>