[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask |
Date: |
Thu, 22 Oct 2020 18:43:56 +0200 |
On Fri, Oct 16, 2020 at 03:08:03PM +0200, Auger Eric wrote:
> > +static int virtio_iommu_set_page_size_mask(IOMMUMemoryRegion *mr,
> > + uint64_t page_size_mask,
> > + Error **errp)
> > +{
> > + int new_granule, old_granule;
> > + IOMMUDevice *sdev = container_of(mr, IOMMUDevice, iommu_mr);
> > + VirtIOIOMMU *s = sdev->viommu;
> > +
> > + if (!page_size_mask) {
> set errp
Woops, fixed
> > + return -1;
> > + }
> > +
> > + new_granule = ctz64(page_size_mask);
> > + old_granule = ctz64(s->config.page_size_mask);
>
> I think this would be interesting to add a trace point
Agreed
Thanks,
Jean
- Re: [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback, (continued)
- [PATCH v10 06/10] virtio-iommu: Add notify_flag_changed() memory region callback, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 07/10] memory: Add interface to set iommu page size mask, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Jean-Philippe Brucker, 2020/10/08
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Auger Eric, 2020/10/16
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask,
Jean-Philippe Brucker <=
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Peter Xu, 2020/10/19
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Jean-Philippe Brucker, 2020/10/22
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Peter Xu, 2020/10/22
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Jean-Philippe Brucker, 2020/10/23
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Peter Xu, 2020/10/23
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Jean-Philippe Brucker, 2020/10/27
- Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Michael S. Tsirkin, 2020/10/30
[PATCH v10 08/10] vfio: Set IOMMU page size as per host supported page size, Jean-Philippe Brucker, 2020/10/08