[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback |
Date: |
Thu, 22 Oct 2020 18:42:09 +0200 |
On Fri, Oct 16, 2020 at 11:12:35AM +0200, Auger Eric wrote:
> > +static gboolean virtio_iommu_remap(gpointer key, gpointer value, gpointer
> > data)
> > +{
> > + VirtIOIOMMUMapping *mapping = (VirtIOIOMMUMapping *) value;
> > + VirtIOIOMMUInterval *interval = (VirtIOIOMMUInterval *) key;
> > + IOMMUMemoryRegion *mr = (IOMMUMemoryRegion *) data;
> > +
> > + trace_virtio_iommu_remap(mr->parent_obj.name, interval->low,
> > interval->high,
> > + mapping->phys_addr);
> > + virtio_iommu_notify_unmap(mr, interval->low, interval->high);
> > + virtio_iommu_notify_map(mr, interval->low, interval->high,
> > + mapping->phys_addr);
> I don't get the preliminary unmap with the same data. Why isn't the map
> sufficient to replay?
>
> The default implementation only notifies for valid entries.
Yes it should be enough, I'll remove the unmap
Thanks,
Jean
- Re: [PATCH v10 01/10] virtio-iommu: Fix virtio_iommu_mr(), (continued)
- [PATCH v10 04/10] virtio-iommu: Call memory notifiers in attach/detach, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 02/10] virtio-iommu: Store memory region in endpoint struct, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 03/10] virtio-iommu: Add memory notifiers for map/unmap, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 06/10] virtio-iommu: Add notify_flag_changed() memory region callback, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 07/10] memory: Add interface to set iommu page size mask, Jean-Philippe Brucker, 2020/10/08
- [PATCH v10 09/10] virtio-iommu: Set supported page size mask, Jean-Philippe Brucker, 2020/10/08