[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id' |
|
Date: |
Wed, 21 Oct 2020 10:08:42 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 10/21/20 9:15 AM, Markus Armbruster wrote:
>> Member 'address' is union GuestDeviceAddress with a single branch
>> GuestDeviceAddressPCI, containing PCI vendor ID and device ID. This
>> is not a PCI address. Type GuestPCIAddress is. Messed up in recent
>> commit 2e4211cee4 "qga: add command guest-get-devices for reporting
>> VirtIO devices".
>
> Out of curiosity, how did you notice?
I searched for simple unions to remind myself of the size of that
problem, and found a new one, i.e. a problem I can still avoid. I
started to do PATCH 4, and noticed the other issues.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
- [PATCH 0/4] qga: Fix several guest-get-devices issues, Markus Armbruster, 2020/10/21
- [PATCH 4/4] qga: Flatten simple union GuestDeviceId, Markus Armbruster, 2020/10/21
- [PATCH 2/4] qga: Use common time encoding for guest-get-devices 'driver-date', Markus Armbruster, 2020/10/21
- [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id', Markus Armbruster, 2020/10/21
- [PATCH 3/4] qga-win: Fix guest-get-devices error API violations, Markus Armbruster, 2020/10/21
- Re: [PATCH 0/4] qga: Fix several guest-get-devices issues, Markus Armbruster, 2020/10/27