|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 4/4] qga: Flatten simple union GuestDeviceId |
Date: | Wed, 21 Oct 2020 09:35:46 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/21/20 9:15 AM, Markus Armbruster wrote:
Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They should be avoided in new code. GuestDeviceId was recently added for guest-get-devices. Convert it to a flat union. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qga/qapi-schema.json | 8 ++++++++ qga/commands-win32.c | 9 ++++----- 2 files changed, 12 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |