[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific comma
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands |
|
Date: |
Mon, 19 Oct 2020 08:30:14 -0400 |
On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote:
> >> Reduce the machine code pulled into qemu-storage-daemon.
> >>
> >> The series is fully Acked, but Markus wants it reviewed
> >> by the Machine core maintainers.
> >
> > I've confirmed that all patches move QAPI schema code without
> > introducing any additional changes.
> >
> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> I take this as "I agree the things moved to machine.json belong there".
> Holler if I'm mistaken.
I agree machine.json is better than misc.json for them, yes.
I miss short descriptions of the purpose of each file, though.
It would help us decide what's appropriate in the future.
--
Eduardo
- [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 1/5] qapi: Restrict 'inject-nmi' command to machine code, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 2/5] qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 3/5] qapi: Restrict '(p)memsave' command to machine code, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 4/5] qapi: Restrict 'query-kvm' command to machine code, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH v2 5/5] qapi: Restrict Xen migration commands to migration.json, Philippe Mathieu-Daudé, 2020/10/12
- Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands, Eduardo Habkost, 2020/10/15
Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands, Markus Armbruster, 2020/10/20