Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

[Eduardo Habkost]

On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote:
> Reduce the machine code pulled into qemu-storage-daemon.
> 
> The series is fully Acked, but Markus wants it reviewed
> by the Machine core maintainers.

I've confirmed that all patches move QAPI schema code without
introducing any additional changes.

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

> 
> Since v1:
> - Added A-b tags
> - Rebased
> 
> Philippe Mathieu-Daudé (5):
>   qapi: Restrict 'inject-nmi' command to machine code
>   qapi: Restrict 'system wakeup/reset/powerdown' commands to
>     machine.json
>   qapi: Restrict '(p)memsave' command to machine code
>   qapi: Restrict 'query-kvm' command to machine code
>   qapi: Restrict Xen migration commands to migration.json
> 
>  qapi/machine.json      | 168 +++++++++++++++++++++++++++++++++
>  qapi/migration.json    |  41 ++++++++
>  qapi/misc.json         | 209 -----------------------------------------
>  accel/stubs/xen-stub.c |   2 +-
>  hw/i386/xen/xen-hvm.c  |   2 +-
>  migration/savevm.c     |   1 -
>  softmmu/cpus.c         |   1 +
>  ui/gtk.c               |   1 +
>  ui/cocoa.m             |   1 +
>  9 files changed, 214 insertions(+), 212 deletions(-)
> 
> -- 
> 2.26.2
> 
> 

-- 
Eduardo