[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/9] kvm: Correct documentation of kvm_irqchip_*()
From: |
Eduardo Habkost |
Subject: |
[PULL 7/9] kvm: Correct documentation of kvm_irqchip_*() |
Date: |
Thu, 15 Oct 2020 12:44:59 -0400 |
When split irqchip support was introduced, the meaning of
kvm_irqchip_in_kernel() changed: now it only means the LAPIC is
in kernel. The PIC, IOAPIC, and PIT might be in userspace if
irqchip=split was set. Update the doc comment to reflect that.
While at it, remove the "the user asked us" part in
kvm_irqchip_is_split() doc comment. That macro has nothing to do
with existence of explicit user-provided options.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200922203612.2178370-1-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/sysemu/kvm.h | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index fe7dab1466..bb5d5cf497 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -51,23 +51,22 @@ extern bool kvm_msi_use_devid;
/**
* kvm_irqchip_in_kernel:
*
- * Returns: true if the user asked us to create an in-kernel
- * irqchip via the "kernel_irqchip=on" machine option.
+ * Returns: true if an in-kernel irqchip was created.
* What this actually means is architecture and machine model
- * specific: on PC, for instance, it means that the LAPIC,
- * IOAPIC and PIT are all in kernel. This function should never
- * be used from generic target-independent code: use one of the
- * following functions or some other specific check instead.
+ * specific: on PC, for instance, it means that the LAPIC
+ * is in kernel. This function should never be used from generic
+ * target-independent code: use one of the following functions or
+ * some other specific check instead.
*/
#define kvm_irqchip_in_kernel() (kvm_kernel_irqchip)
/**
* kvm_irqchip_is_split:
*
- * Returns: true if the user asked us to split the irqchip
- * implementation between user and kernel space. The details are
- * architecture and machine specific. On PC, it means that the PIC,
- * IOAPIC, and PIT are in user space while the LAPIC is in the kernel.
+ * Returns: true if the irqchip implementation is split between
+ * user and kernel space. The details are architecture and
+ * machine specific. On PC, it means that the PIC, IOAPIC, and
+ * PIT are in user space while the LAPIC is in the kernel.
*/
#define kvm_irqchip_is_split() (kvm_split_irqchip)
--
2.28.0
- [PULL 0/9] x86 queue, 2020-10-15, Eduardo Habkost, 2020/10/15
- [PULL 1/9] i386: drop x86_cpu_get_supported_feature_word() forward declaration, Eduardo Habkost, 2020/10/15
- [PULL 8/9] cpu: Introduce CPU model deprecation API, Eduardo Habkost, 2020/10/15
- [PULL 3/9] target/i386: Remove core_id assert check in CPUID 0x8000001E, Eduardo Habkost, 2020/10/15
- [PULL 2/9] i386/kvm: fix FEATURE_HYPERV_EDX value in hyperv_passthrough case, Eduardo Habkost, 2020/10/15
- [PULL 4/9] i386/kvm: Require KVM_CAP_IRQ_ROUTING, Eduardo Habkost, 2020/10/15
- [PULL 5/9] i386/kvm: Remove IRQ routing support checks, Eduardo Habkost, 2020/10/15
- [PULL 6/9] i386/kvm: Delete kvm_allows_irq0_override(), Eduardo Habkost, 2020/10/15
- [PULL 7/9] kvm: Correct documentation of kvm_irqchip_*(),
Eduardo Habkost <=
- [PULL 9/9] i386: Mark Icelake-Client CPU models deprecated, Eduardo Habkost, 2020/10/15
- Re: [PULL 0/9] x86 queue, 2020-10-15, Peter Maydell, 2020/10/17