[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/10] Optimize seq_sorter function for colo-compare
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 02/10] Optimize seq_sorter function for colo-compare |
Date: |
Thu, 15 Oct 2020 13:06:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/14/20 9:25 AM, Zhang Chen wrote:
From: "Rao, Lei" <lei.rao@intel.com>
The seq of tcp has been filled in fill_pkt_tcp_info, it
can be used directly here.
Signed-off-by: leirao <lei.rao@intel.com>
"Signed-off-by: Lei Rao <lei.rao@intel.com>"?
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
---
net/colo-compare.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 3a45d64175..86980cef5e 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -196,11 +196,7 @@ static void colo_compare_inconsistency_notify(CompareState
*s)
Maybe add a comment /* Use restricted to colo_insert_packet() */
Because if someone use it elsewhere it will now be buggy.
static gint seq_sorter(Packet *a, Packet *b, gpointer data)
{
- struct tcp_hdr *atcp, *btcp;
-
- atcp = (struct tcp_hdr *)(a->transport_header);
- btcp = (struct tcp_hdr *)(b->transport_header);
- return ntohl(atcp->th_seq) - ntohl(btcp->th_seq);
+ return a->tcp_seq - b->tcp_seq;
}
static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)
- [PATCH 00/10] COLO project queued patches 20-Oct, Zhang Chen, 2020/10/14
- [PATCH 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup, Zhang Chen, 2020/10/14
- [PATCH 02/10] Optimize seq_sorter function for colo-compare, Zhang Chen, 2020/10/14
- Re: [PATCH 02/10] Optimize seq_sorter function for colo-compare,
Philippe Mathieu-Daudé <=
- [PATCH 03/10] Reduce the time of checkpoint for COLO, Zhang Chen, 2020/10/14
- [PATCH 04/10] Fix the qemu crash when guest shutdown in COLO mode, Zhang Chen, 2020/10/14
- [PATCH 05/10] colo-compare: fix missing compare_seq initialization, Zhang Chen, 2020/10/14
- [PATCH 06/10] colo-compare: check mark in mutual exclusion, Zhang Chen, 2020/10/14
- [PATCH 07/10] net/colo-compare.c: Fix compare_timeout format issue, Zhang Chen, 2020/10/14
- [PATCH 08/10] net/colo-compare.c: Change the timer clock type, Zhang Chen, 2020/10/14