[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 03/10] Reduce the time of checkpoint for COLO
From: |
Zhang, Chen |
Subject: |
RE: [PATCH 03/10] Reduce the time of checkpoint for COLO |
Date: |
Wed, 14 Oct 2020 12:16:04 +0000 |
> -----Original Message-----
> From: Zhang Chen <chen.zhang@intel.com>
> Sent: Wednesday, October 14, 2020 3:26 PM
> To: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
> devel@nongnu.org>
> Cc: Zhang Chen <zhangckid@gmail.com>; Rao, Lei <lei.rao@intel.com>;
> Zhang, Chen <chen.zhang@intel.com>
> Subject: [PATCH 03/10] Reduce the time of checkpoint for COLO
>
> From: "Rao, Lei" <lei.rao@intel.com>
>
> we should set ram_bulk_stage to false after ram_state_init, otherwise the
> bitmap will be unused in migration_bitmap_find_dirty.
> all pages in ram cache will be flushed to the ram of secondary guest for each
> checkpoint.
>
> Signed-off-by: leirao <lei.rao@intel.com>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Sorry, I forgot to add:
Signed-off-by: Derek Su <dereksu@qnap.com>
Thanks
Zhang Chen
> ---
> migration/ram.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c index 433489d633..9cfac3d9ba
> 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -3009,6 +3009,18 @@ static void
> decompress_data_with_multi_threads(QEMUFile *f,
> qemu_mutex_unlock(&decomp_done_lock);
> }
>
> + /*
> + * we must set ram_bulk_stage to false, otherwise in
> + * migation_bitmap_find_dirty the bitmap will be unused and
> + * all the pages in ram cache wil be flushed to the ram of
> + * secondary VM.
> + */
> +static void colo_init_ram_state(void)
> +{
> + ram_state_init(&ram_state);
> + ram_state->ram_bulk_stage = false;
> +}
> +
> /*
> * colo cache: this is for secondary VM, we cache the whole
> * memory of the secondary VM, it is need to hold the global lock @@ -
> 3052,7 +3064,7 @@ int colo_init_ram_cache(void)
> }
> }
>
> - ram_state_init(&ram_state);
> + colo_init_ram_state();
> return 0;
> }
>
> --
> 2.17.1
- [PATCH 00/10] COLO project queued patches 20-Oct, Zhang Chen, 2020/10/14
- [PATCH 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup, Zhang Chen, 2020/10/14
- [PATCH 02/10] Optimize seq_sorter function for colo-compare, Zhang Chen, 2020/10/14
- [PATCH 03/10] Reduce the time of checkpoint for COLO, Zhang Chen, 2020/10/14
- RE: [PATCH 03/10] Reduce the time of checkpoint for COLO,
Zhang, Chen <=
- [PATCH 04/10] Fix the qemu crash when guest shutdown in COLO mode, Zhang Chen, 2020/10/14
- [PATCH 05/10] colo-compare: fix missing compare_seq initialization, Zhang Chen, 2020/10/14
- [PATCH 06/10] colo-compare: check mark in mutual exclusion, Zhang Chen, 2020/10/14
- [PATCH 07/10] net/colo-compare.c: Fix compare_timeout format issue, Zhang Chen, 2020/10/14
- [PATCH 08/10] net/colo-compare.c: Change the timer clock type, Zhang Chen, 2020/10/14
- [PATCH 09/10] net/colo-compare.c: Add secondary old packet detection, Zhang Chen, 2020/10/14
- Re: [PATCH 00/10] COLO project queued patches 20-Oct, Jason Wang, 2020/10/15