[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/10] authz-list-file: Fix crash when filename is not set
From: |
Eduardo Habkost |
Subject: |
[PULL 09/10] authz-list-file: Fix crash when filename is not set |
Date: |
Wed, 14 Oct 2020 10:34:14 -0400 |
Fix the following crash:
$ qemu-system-x86_64 -object authz-list-file,id=obj0
qemu-system-x86_64: -object authz-list-file,id=obj0: GLib:
g_file_get_contents: assertion 'filename != NULL' failed
Segmentation fault (core dumped)
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20201008202713.1416823-2-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
authz/listfile.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/authz/listfile.c b/authz/listfile.c
index cd6163aa40..aaf930453d 100644
--- a/authz/listfile.c
+++ b/authz/listfile.c
@@ -122,6 +122,11 @@ qauthz_list_file_complete(UserCreatable *uc, Error **errp)
QAuthZListFile *fauthz = QAUTHZ_LIST_FILE(uc);
gchar *dir = NULL, *file = NULL;
+ if (!fauthz->filename) {
+ error_setg(errp, "filename not provided");
+ return;
+ }
+
fauthz->list = qauthz_list_file_load(fauthz, errp);
if (!fauthz->refresh) {
--
2.28.0
- [PULL 00/10] machine + QOM queue, 2020-10-14, Eduardo Habkost, 2020/10/14
- [PULL 02/10] rng-random: register "filename" as class property, Eduardo Habkost, 2020/10/14
- [PULL 01/10] rng-egd: Register "chardev" as class property, Eduardo Habkost, 2020/10/14
- [PULL 04/10] input-linux: Register properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 05/10] input-barrier: Register properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 03/10] rng: Register "opened" as class property, Eduardo Habkost, 2020/10/14
- [PULL 06/10] i386: Register most CPU properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 07/10] vga-pci: Register "big-endian-framebuffer" as class property, Eduardo Habkost, 2020/10/14
- [PULL 10/10] can-host-socketcan: Fix crash when 'if' option is not set, Eduardo Habkost, 2020/10/14
- [PULL 09/10] authz-list-file: Fix crash when filename is not set,
Eduardo Habkost <=
- [PULL 08/10] vhost-user: Register "chardev" as class property, Eduardo Habkost, 2020/10/14
- Re: [PULL 00/10] machine + QOM queue, 2020-10-14, Peter Maydell, 2020/10/15